Received-SPF: pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Sender: "mmandlik via sendgmr" <mmandlik@mmandlik.mtv.corp.google.com>
Date:   Wed,  2 Dec 2020 19:46:52 -0800
In-Reply-To: <20201202194547.bluez.v2.1.Idce75740a54d8a860450da8a7a21d55777c87ae9@changeid>
Message-Id: <20201202194547.bluez.v2.2.Ic1f25ec863fe218390cfbe5e5252f787a4475d3b@changeid>
Mime-Version: 1.0
References: <20201202194547.bluez.v2.1.Idce75740a54d8a860450da8a7a21d55777c87ae9@changeid>
Subject: [bluez PATCH v2 2/2] client: Use correct root path for RegisterMonitor
From:   Manish Mandlik <mmandlik@google.com>
To:     marcel@holtmann.org, luiz.dentz@gmail.com
Cc:     linux-bluetooth@vger.kernel.org,
        chromeos-bluetooth-upstreaming@chromium.org,
        Manish Mandlik <mmandlik@google.com>, sonnysasaka@chromium.org,
        mcchou@chromium.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Bluetoothctl uses "/" as the app root path. So, use the same
app root path while invoking RegisterMonitor method. This will
also ensure that InterfacesAdded/InterfacesRemoved signals are
emitted on the correct app root path.

Signed-off-by: Manish Mandlik <mmandlik@google.com>
Reviewed-by: sonnysasaka@chromium.org
Reviewed-by: mcchou@chromium.org

---

Changes in v2:
- per discussion, discarded gdbus library changes and fixed bluetoothctl
  code to use correct root path i.e. "/" while invoking RegisterMonitor

 client/adv_monitor.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/client/adv_monitor.c b/client/adv_monitor.c
index 8e81857af..f62e9f444 100644
--- a/client/adv_monitor.c
+++ b/client/adv_monitor.c
@@ -270,7 +270,7 @@ void adv_monitor_remove_manager(DBusConnection *conn)
 
 static void register_setup(DBusMessageIter *iter, void *user_data)
 {
-	const char *path = ADV_MONITOR_APP_PATH;
+	const char *path = "/";
 
 	dbus_message_iter_append_basic(iter, DBUS_TYPE_OBJECT_PATH, &path);
 }
@@ -293,7 +293,7 @@ static void register_reply(DBusMessage *message, void *user_data)
 
 static void unregister_setup(DBusMessageIter *iter, void *user_data)
 {
-	const char *path = ADV_MONITOR_APP_PATH;
+	const char *path = "/";
 
 	dbus_message_iter_append_basic(iter, DBUS_TYPE_OBJECT_PATH, &path);
 }
-- 
2.29.2.454.gaff20da3a2-goog