Received-SPF: pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Fri, 4 Dec 2020 16:09:24 -0800
From:   Jakub Kicinski <kuba@kernel.org>
To:     "Enrico Weigelt, metux IT consult" <info@metux.net>
Cc:     linux-kernel@vger.kernel.org, davem@davemloft.net,
        mareklindner@neomailbox.ch, sw@simonwunderlich.de, a@unstable.cc,
        sven@narfation.org, marcel@holtmann.org, johan.hedberg@gmail.com,
        roopa@nvidia.com, nikolay@nvidia.com, edumazet@google.com,
        kuznet@ms2.inr.ac.ru, yoshfuji@linux-ipv6.org, jmaloy@redhat.com,
        ying.xue@windriver.com, kafai@fb.com, songliubraving@fb.com,
        yhs@fb.com, john.fastabend@gmail.com, kpsingh@chromium.org,
        netdev@vger.kernel.org, linux-bluetooth@vger.kernel.org,
        tipc-discussion@lists.sourceforge.net,
        linux-hyperv@vger.kernel.org, bpf@vger.kernel.org
Subject: Re: [PATCH 1/7] net: 8021q: remove unneeded MODULE_VERSION() usage
Message-ID: <20201204160924.2e170514@kicinski-fedora-pc1c0hjn.DHCP.thefacebook.com>
In-Reply-To: <20201202124959.29209-1-info@metux.net>
References: <20201202124959.29209-1-info@metux.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Wed,  2 Dec 2020 13:49:53 +0100 Enrico Weigelt, metux IT consult
wrote:
> Remove MODULE_VERSION(), as it isn't needed at all: the only version
> making sense is the kernel version.
> 
> Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>

Thanks for the patches. Please drop the "metux IT consult" from the
addresses. The from space is supposed to be for your name.

> diff --git a/net/8021q/vlan.c b/net/8021q/vlan.c
> index f292e0267bb9..683e9e825b9e 100644
> --- a/net/8021q/vlan.c
> +++ b/net/8021q/vlan.c
> @@ -36,15 +36,10 @@
>  #include "vlan.h"
>  #include "vlanproc.h"
>  
> -#define DRV_VERSION "1.8"
> -
>  /* Global VLAN variables */
>  
>  unsigned int vlan_net_id __read_mostly;
>  
> -const char vlan_fullname[] = "802.1Q VLAN Support";
> -const char vlan_version[] = DRV_VERSION;

This patches does not build. Please redo it more carefully.

You'll need to fix and resend the entire series. When you do so please
provide a cover letter, even if it only contains a couple of sentences
and separate the patches for bluetooth and batman-adv out as stand
alone patches, so the respective maintainers can pick them up.