Received-SPF: pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Sat, 5 Dec 2020 08:56:04 -0800
From:   Jakub Kicinski <kuba@kernel.org>
To:     Sven Eckelmann <sven@narfation.org>
Cc:     linux-kernel@vger.kernel.org,
        "Enrico Weigelt, metux IT consult" <info@metux.net>,
        davem@davemloft.net, mareklindner@neomailbox.ch,
        sw@simonwunderlich.de, a@unstable.cc, marcel@holtmann.org,
        johan.hedberg@gmail.com, roopa@nvidia.com, nikolay@nvidia.com,
        edumazet@google.com, kuznet@ms2.inr.ac.ru, yoshfuji@linux-ipv6.org,
        jmaloy@redhat.com, ying.xue@windriver.com, kafai@fb.com,
        songliubraving@fb.com, yhs@fb.com, john.fastabend@gmail.com,
        kpsingh@chromium.org, netdev@vger.kernel.org,
        linux-bluetooth@vger.kernel.org,
        tipc-discussion@lists.sourceforge.net,
        linux-hyperv@vger.kernel.org, bpf@vger.kernel.org,
        Matthias Schiffer <mschiffer@universe-factory.net>
Subject: Re: [PATCH 2/7] net: batman-adv: remove unneeded MODULE_VERSION()
 usage
Message-ID: <20201205085604.1e3fcaee@kicinski-fedora-pc1c0hjn.DHCP.thefacebook.com>
In-Reply-To: <4581108.GXAFRqVoOG@sven-edge>
References: <20201202124959.29209-1-info@metux.net>
        <20201202124959.29209-2-info@metux.net>
        <4581108.GXAFRqVoOG@sven-edge>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Sat, 05 Dec 2020 08:06:40 +0100 Sven Eckelmann wrote:
> On Wednesday, 2 December 2020 13:49:54 CET Enrico Weigelt, metux IT consult wrote:
> > Remove MODULE_VERSION(), as it isn't needed at all: the only version
> > making sense is the kernel version.  
> 
> Is there some explanation besides an opinion? Some kind goal which you want to 
> achieve with it maybe?
> 
> At least for us it was an easy way to query the release cycle information via 
> batctl. Which made it easier for us to roughly figure out what an reporter/
> inquirer was using - independent of whether he is using the in-kernel version 
> or a backported version.
> 
> Loosing this source of information and breaking parts of batctl and other 
> tools (respondd, ...) is not the end of the world. But I would at least know 
> why this is now necessary.

No, no, if it breaks your user space we can't do it, let's leave batman
alone, then.

I think this is mostly a clean up. In-tree the kernel version is usually
far more dependable because backports don't include version bumps.

Indeed it would be great if the clear motivation was spelled out in the
cover letter and/or patches.