Received-SPF: pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
From:   Lionel Jeanson <lionel.jeanson@gmail.com>
Date:   Mon, 7 Dec 2020 18:04:10 +0100
Message-ID: <CAMxp894ThdL9qxNz49561WrDj3XhWxpFMf+9afMD9WqMbSPBbw@mail.gmail.com>
Subject: sixaxis patch proposal
To:     linux-bluetooth@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Hi;

I'd like to propose the following patch to fix the following issue :

 - if an already paired PS3 DualShock is plugged to USB, while it is
turned off (PS button wasn't pushed or no more battery for instance),
then it's connection will be reset and it will have to be paired again

 - to fix this, I removed the device connection check

 - tested on Ubuntu 20.x (bluez-5.53 and bluez-5.55) and works fine in
all cases.

Thank you;
Lionel


diff --git a/plugins/sixaxis.c b/plugins/sixaxis.c
index d693a86c0..ccede193e 100644
--- a/plugins/sixaxis.c
+++ b/plugins/sixaxis.c
@@ -337,7 +337,6 @@ static bool setup_device(int fd, const char *sysfs_path,
        device = btd_adapter_find_device(adapter, &device_bdaddr,
                                                        BDADDR_BREDR);
        if (device != NULL &&
-               btd_device_is_connected(device) &&
                g_slist_find_custom(btd_device_get_uuids(device), HID_UUID,
                                                (GCompareFunc)strcasecmp)) {
                char device_addr[18];