Received-SPF: pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH 2/7] net: batman-adv: remove unneeded MODULE_VERSION()
 usage
To:     Sven Eckelmann <sven@narfation.org>, linux-kernel@vger.kernel.org,
        "Enrico Weigelt, metux IT consult" <info@metux.net>
Cc:     davem@davemloft.net, kuba@kernel.org, mareklindner@neomailbox.ch,
        sw@simonwunderlich.de, a@unstable.cc, marcel@holtmann.org,
        johan.hedberg@gmail.com, roopa@nvidia.com, nikolay@nvidia.com,
        edumazet@google.com, kuznet@ms2.inr.ac.ru, yoshfuji@linux-ipv6.org,
        jmaloy@redhat.com, ying.xue@windriver.com, kafai@fb.com,
        songliubraving@fb.com, yhs@fb.com, john.fastabend@gmail.com,
        kpsingh@chromium.org, netdev@vger.kernel.org,
        linux-bluetooth@vger.kernel.org,
        tipc-discussion@lists.sourceforge.net,
        linux-hyperv@vger.kernel.org, bpf@vger.kernel.org,
        Matthias Schiffer <mschiffer@universe-factory.net>
References: <20201202124959.29209-1-info@metux.net>
 <20201202124959.29209-2-info@metux.net> <4581108.GXAFRqVoOG@sven-edge>
From:   "Enrico Weigelt, metux IT consult" <lkml@metux.net>
Message-ID: <ca5c17a1-dea5-83eb-f9c5-a027b4135fec@metux.net>
Date:   Tue, 8 Dec 2020 08:48:56 +0100
User-Agent: Mozilla/5.0 (X11; Linux i686 on x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.12.0
MIME-Version: 1.0
In-Reply-To: <4581108.GXAFRqVoOG@sven-edge>
Content-Type: text/plain; charset=windows-1252
Content-Language: tl
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 05.12.20 08:06, Sven Eckelmann wrote:

Hi,

> Is there some explanation besides an opinion? Some kind goal which you want to 
> achieve with it maybe?

Just a cleanup. I've been under the impression that this version is just
an relic from oot times.

> At least for us it was an easy way to query the release cycle information via 
> batctl. Which made it easier for us to roughly figure out what an reporter/
> inquirer was using - independent of whether he is using the in-kernel version 
> or a backported version.

Is the OOT scenario still valid ?

> Loosing this source of information and breaking parts of batctl and other 
> tools (respondd, ...) is not the end of the world. But I would at least know 
> why this is now necessary.

Okay, if this particular information indeed has a practical value, we
should keep it. Taking it as a NAK.

Perhaps we should add a comment what it's used for and make sure, the
version number is properly maintained.

The problem I see w/ those version fields is that we have lots of
changes in the kernel tree, w/o the version number being increased -
making this information at least doubtful.


--mtx

-- 
---
Hinweis: unverschl?sselte E-Mails k?nnen leicht abgeh?rt und manipuliert
werden ! F?r eine vertrauliche Kommunikation senden Sie bitte ihren
GPG/PGP-Schl?ssel zu.
---
Enrico Weigelt, metux IT consult
Free software and Linux embedded engineering
info@metux.net -- +49-151-27565287