Received-SPF: pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <2fb922ffced103ba09571567366968d5462f9267.camel@hadess.net>
Subject: Re: sixaxis patch proposal
From:   Bastien Nocera <hadess@hadess.net>
To:     Lionel Jeanson <lionel.jeanson@gmail.com>,
        linux-bluetooth@vger.kernel.org
Date:   Tue, 08 Dec 2020 10:01:03 +0100
In-Reply-To: <CAMxp894ThdL9qxNz49561WrDj3XhWxpFMf+9afMD9WqMbSPBbw@mail.gmail.com>
References: <CAMxp894ThdL9qxNz49561WrDj3XhWxpFMf+9afMD9WqMbSPBbw@mail.gmail.com>
Content-Type: text/plain; charset="UTF-8"
User-Agent: Evolution 3.38.1 (3.38.1-1.fc33) 
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Precedence: bulk

On Mon, 2020-12-07 at 18:04 +0100, Lionel Jeanson wrote:
> Hi;
> 
> I'd like to propose the following patch to fix the following issue :
> 
>  - if an already paired PS3 DualShock is plugged to USB, while it is
> turned off (PS button wasn't pushed or no more battery for instance),
> then it's connection will be reset and it will have to be paired
> again
> 
>  - to fix this, I removed the device connection check
> 
>  - tested on Ubuntu 20.x (bluez-5.53 and bluez-5.55) and works fine
> in
> all cases.

It doesn't have to be paired again if the pairing agent doesn't accept
the pairing.

Also, see 7bb73f092a.