Received: by 2002:a05:6a10:f347:0:0:0:0 with SMTP id d7csp2452209pxu; Fri, 18 Dec 2020 13:45:22 -0800 (PST) X-Google-Smtp-Source: ABdhPJz+6cU2wmRELmvMQn3DK6t9OnF/tz3VSpE4ZT0JQyQfPOvPL/6de+T7PujoBkZOzSINzfWP X-Received: by 2002:a17:906:add7:: with SMTP id lb23mr6230036ejb.352.1608327922130; Fri, 18 Dec 2020 13:45:22 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1608327922; cv=none; d=google.com; s=arc-20160816; b=BPWsWZYn+RuTRnykxOhgSdQDPKZSPqUBV/v9mNaEBLFUfAUmRgH0gn6icjDrERZilk M/CRQNnobDas/xogs7z/V0zueYz/IOytYal9sffleCC9YOqIsviTjRHMt0mB+N7mkzvy UD20Jb5FFiqvZ5GC4KrFUGtCQX6lIycOpkVqmZxhQux4AyZCR5TYtlwmXG8b6lG2QC7F YlOPqqHIKng8TE4hzD9iHUwBm1InhCdJ5J0l/mBV9+ETclo41nII9KMV5+uezOI6L5qz FAXRX0HGMlL/zwChcIbzJ7NLeAQ1z1CjsNfGYNjyAA28ksBkDYdVWdF28h1taee7zcRI q5OA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:to:references:message-id :content-transfer-encoding:cc:date:in-reply-to:from:subject :mime-version; bh=V+R7GeiIJgnE7CaWNsUVEG8kq54lIOBresxFcqT4NzE=; b=XXue+gjZxG4XVYdLE8iSlVPDTclrfahCamWIH9imVDwXpR4u2HIOJnYDwcCgV5S50Y Be6IQCbjFSK7ptqbphJzg7TzhVSRLa7Qz1/4wGnMqBYh5UVaPSw4SW6hpLIclPfZAWui StKmnLI32ZqWLPgjzXHDTSPo0mKZrAD4+VkC3yL64GibVzcYTTKTu3Qw+gKmGfMlnakg XFiIVVROTt+ePh4TQ/bHhmkw6odudLy8UIByWxhlTLE7NE2uRPt2RCWg86lDmg4mEjDj JqWC8XqhLJfgc8dQR8NZvKId0wzLqNGrnLTGlgpx/dGgN3qb+YIdjIwsGNjIjqcJXOU4 q8oQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-bluetooth-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id l3si4227955edq.175.2020.12.18.13.44.59; Fri, 18 Dec 2020 13:45:22 -0800 (PST) Received-SPF: pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-bluetooth-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725966AbgLRVoG (ORCPT + 99 others); Fri, 18 Dec 2020 16:44:06 -0500 Received: from coyote.holtmann.net ([212.227.132.17]:46708 "EHLO mail.holtmann.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725778AbgLRVoF (ORCPT ); Fri, 18 Dec 2020 16:44:05 -0500 Received: from marcel-macbook.holtmann.net (p4fefcdf9.dip0.t-ipconnect.de [79.239.205.249]) by mail.holtmann.org (Postfix) with ESMTPSA id 92D3ACED31; Fri, 18 Dec 2020 22:50:41 +0100 (CET) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.40.0.2.32\)) Subject: Re: [PATCH v1] Revert "Bluetooth: btintel: Fix endianness issue for TLV version information" From: Marcel Holtmann In-Reply-To: <20201215234038.31975-1-kiran.k@intel.com> Date: Fri, 18 Dec 2020 22:43:24 +0100 Cc: linux-bluetooth@vger.kernel.org, ravishankar.srivatsa@intel.com, chethan.tumkur.narayan@intel.com Content-Transfer-Encoding: 7bit Message-Id: <3E47AC85-4F09-490F-9BDA-2D2B217B9BE5@holtmann.org> References: <20201215234038.31975-1-kiran.k@intel.com> To: Kiran K X-Mailer: Apple Mail (2.3654.40.0.2.32) Precedence: bulk List-ID: X-Mailing-List: linux-bluetooth@vger.kernel.org Hi Kiran, > This reverts commit a63f23c9d139377833a139b179793fea79ee198f. > > get_unaligned_{le16|le32|le64}(p) is meant to replace code of the form > le16_to_cpu(get_unaligned((__le16 *)p)). There is no need to explicitly > do leXX_to_cpu() if get_unaligned_leXX() is used. > > https://lwn.net/Articles/277779/ > > Reported-by: kernel test robot > Signed-off-by: Kiran K > --- > drivers/bluetooth/btintel.c | 21 +++++++-------------- > 1 file changed, 7 insertions(+), 14 deletions(-) patch has been applied to bluetooth-next tree. Regards Marcel