Received-SPF: pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 22 Dec 2020 13:40:24 +0200
From:   Pasi =?iso-8859-1?Q?K=E4rkk=E4inen?= <pasik@iki.fi>
To:     Pali =?iso-8859-1?Q?Roh=E1r?= <pali@kernel.org>
Cc:     Joakim Tjernlund <Joakim.Tjernlund@infinera.com>,
        "linux-bluetooth@vger.kernel.org" <linux-bluetooth@vger.kernel.org>
Subject: Re: Default to HW mSBC on capable controllers ?
Message-ID: <20201222114024.GG20371@reaktio.net>
References: <CY4PR1001MB2389075CC44E480B446535E5F4C30@CY4PR1001MB2389.namprd10.prod.outlook.com>
 <20201221210707.evrdeyiki45pivux@pali>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20201221210707.evrdeyiki45pivux@pali>
User-Agent: Mutt/1.5.23 (2014-03-12)
Precedence: bulk

Hello Pali,

On Mon, Dec 21, 2020 at 10:07:07PM +0100, Pali Roh?r wrote:
> 
> > Any idea if one could patch the kernel to default to HW mSBC and user apps like bluealsa/pulseaudio would just use it automatically?
> 
> For usage mSBC hw encoder you need to use Enhanced Setup Synchronous
> Connection HCI command for establishing SCO connection.
> 
> For using HW encoder you need to stop feeding socket with mSBC encoded
> data and instead put into this socket RAW pcm samples. Also you need
> somehow inform kernel about this change.
> 
> For both things I designed new setsockopt() API which I described in:
> https://lore.kernel.org/linux-bluetooth/20200419234937.4zozkqgpt557m3o6@pali/
>

In that thread Luiz asked for changes to the patch, eg. kernel module option is needed which allows enabling new/experimental features, and your changes should be enabled only when experimental option is given while loading the module.

See here:
https://lore.kernel.org/linux-bluetooth/CABBYNZJTBM87Yr+rqUm6MwwSR60YNe+UFr0HHj5T2DkY7LqJqA@mail.gmail.com/

Could you please add that kernel module option, and re-send the patch ? 


Thanks,

-- Pasi