Received-SPF: pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <CABBYNZJ1PGCTVEon28vBN0apNjne2r5NgHY8e1WDtDML+4aeEw@mail.gmail.com>
 <20201222110424.19368-1-marius@devup.no>
In-Reply-To: <20201222110424.19368-1-marius@devup.no>
From:   Luiz Augusto von Dentz <luiz.dentz@gmail.com>
Date:   Tue, 22 Dec 2020 13:17:08 -0800
Message-ID: <CABBYNZ+=vC78xKmn=242+Le1w9f6Zg3srWLmvv+w+JYbf4q2Dw@mail.gmail.com>
Subject: Re: [PATCH v3] sbc_primitives: Fix build on non-x86.
To:     Marius Bakke <marius@devup.no>
Cc:     Marcel Holtmann <marcel@holtmann.org>,
        Luiz Augusto von Dentz <luiz.von.dentz@intel.com>,
        "linux-bluetooth@vger.kernel.org" <linux-bluetooth@vger.kernel.org>,
        Marius Bakke <marius@gnu.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Hi Marius,

On Tue, Dec 22, 2020 at 3:07 AM Marius Bakke <marius@devup.no> wrote:
>
> From: Marius Bakke <marius@gnu.org>
>
> Don't call __builtin_cpu_init unless targeting i386 or x86_64.
> Otherwise we get an error at link time:
>
>   CC       sbc/sbc_primitives.lo
> sbc/sbc_primitives.c: In function =E2=80=98sbc_init_primitives_x86=E2=80=
=99:
> sbc/sbc_primitives.c:596:2: warning: implicit declaration of function =E2=
=80=98__builtin_cpu_init=E2=80=99; did you mean =E2=80=98__builtin_irint=E2=
=80=99? [-Wimplicit-function-declaration]
> [...]
>   CCLD     src/sbcdec
> ld: sbc/.libs/libsbc-private.a(sbc_primitives.o): in function `sbc_init_p=
rimitives':
> sbc_primitives.c:(.text+0x3a30): undefined reference to `__builtin_cpu_in=
it'
> ---
>  sbc/sbc_primitives.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/sbc/sbc_primitives.c b/sbc/sbc_primitives.c
> index 97a75be..09c214a 100644
> --- a/sbc/sbc_primitives.c
> +++ b/sbc/sbc_primitives.c
> @@ -593,6 +593,7 @@ static int sbc_calc_scalefactors_j(
>
>  static void sbc_init_primitives_x86(struct sbc_encoder_state *state)
>  {
> +#if defined(__x86_64__) || defined(__i386__)
>         __builtin_cpu_init();
>
>  #ifdef SBC_BUILD_WITH_MMX_SUPPORT
> @@ -604,6 +605,7 @@ static void sbc_init_primitives_x86(struct sbc_encode=
r_state *state)
>         if (__builtin_cpu_supports("sse4.2"))
>                 sbc_init_primitives_sse(state);
>  #endif
> +#endif
>  }
>
>  /*
> --
> 2.29.2

Applied, thanks.

--=20
Luiz Augusto von Dentz