Received: by 2002:a05:6a10:f347:0:0:0:0 with SMTP id d7csp8605772pxu; Sun, 27 Dec 2020 12:39:30 -0800 (PST) X-Google-Smtp-Source: ABdhPJwdETL+VU6rY3qs03yt/jXwS+i4B2d8EN7a6rgCBe+MJCkHK3IJYWNmyOM6EBFyccgLStHs X-Received: by 2002:a17:906:ae4e:: with SMTP id lf14mr40598602ejb.310.1609101570707; Sun, 27 Dec 2020 12:39:30 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1609101570; cv=none; d=google.com; s=arc-20160816; b=imCVs/pGSaiSncTfuMxqiv7H0NAJqKlNgR/RUgblgCIn+KR54nQ277bUx4uG6Vyczo MCLmwG0PSiKz//SXoQqdk9mXeXYl+4kqQpU10lT0eGjVeuu81HIOnDShEVwODCwZEUZe DhshGydBw38zWoKmuwiiWoM8S778Db3/6KykGZKHTq5teXZ7PrJ6/PAx4HyV5dzVGeUa 47J73R2t1B22vg0NBEaVkVqheFTkq7IHiYlfB2IcHYiYljazV4JLYlM2uLC0MiXzfekv Z2eoR/U/ybJhMBh0dWK2rrhU2ktoRPVPrYcgGQJTltx/hlTgX42VGQ2xPWUugqjjYGGp 3xSg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:to:references:message-id :content-transfer-encoding:cc:date:in-reply-to:from:subject :mime-version; bh=lYL35ZkhR2Rtl5ftClhymEaisp+aBynHmTTTmDozdes=; b=Qe16Q0M5RANHRllBsKB1ZjIs2pi4ODWCpYbfRoIL/WG2lNxxc5GqAW8YuEp+Xkr9/V kCX3Kn/a9s6HqdZ0/C5vuy2xmZ0E6/6F7JvkEn+lgRFTfTHd02v+o/cz1p642bwE+/c/ uGFDfVbuFetNT5o/Cw/+pWu+c8w7AbEV7mMC+6pLVTI+XtMlSoiRMzhKemmKcL8cdDxp 18UcZdl49g0OMv+U9xTimzqMSUy0RsZXJmanf1q+yIt2rWsowek4A9ApFyAayne5kBc5 oIm5t95grMkdk+9jtjP/4lqYnvFFiF8QRSI7Lt+ToGBoltHlNIRLEFs6PZ9eXKb+DUGS tCzg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-bluetooth-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id w8si17161151ejv.203.2020.12.27.12.38.45; Sun, 27 Dec 2020 12:39:30 -0800 (PST) Received-SPF: pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-bluetooth-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726204AbgL0Ug7 convert rfc822-to-8bit (ORCPT + 99 others); Sun, 27 Dec 2020 15:36:59 -0500 Received: from coyote.holtmann.net ([212.227.132.17]:34742 "EHLO mail.holtmann.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726067AbgL0Ug7 (ORCPT ); Sun, 27 Dec 2020 15:36:59 -0500 Received: from marcel-macbook.holtmann.net (p4ff9f924.dip0.t-ipconnect.de [79.249.249.36]) by mail.holtmann.org (Postfix) with ESMTPSA id DB1C8CECDB; Sun, 27 Dec 2020 21:43:36 +0100 (CET) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.40.0.2.32\)) Subject: Re: [PATCH] Fix initializing response id after clearing struct From: Marcel Holtmann In-Reply-To: Date: Sun, 27 Dec 2020 21:36:17 +0100 Cc: linux-bluetooth@vger.kernel.org Content-Transfer-Encoding: 8BIT Message-Id: References: To: Christopher William Snowhill X-Mailer: Apple Mail (2.3654.40.0.2.32) Precedence: bulk List-ID: X-Mailing-List: linux-bluetooth@vger.kernel.org Hi Christopher, > Looks like this was missed when patching the source to clear the structures throughout, causing this one instance to clear the struct after the response id is assigned. > > This is in regard to Message ID <20200806181714.3216076-1-luiz.dentz@gmail.com>, > subject: [PATCH 1/4] Bluetooth: A2MP: Fix not initializing all members > > I must apologize for not noticing this sooner, as I remember reading the articles linking to this patch several months ago. Either it slipped my mind, or I failed to notice it then. Apparently, nobody else noticed it, either, so I guess it's just not that obvious. > > --- > net/bluetooth/a2mp.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) patch has been applied to bluetooth-next tree. Regards Marcel