Received-SPF: pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210105111219.Bluez.v4.1.Ie32770d0eed2e7739ce9d17d920766fb6aee8583@changeid>
 <5ff3e8b4.1c69fb81.827b.74bf@mx.google.com>
In-Reply-To: <5ff3e8b4.1c69fb81.827b.74bf@mx.google.com>
From:   Luiz Augusto von Dentz <luiz.dentz@gmail.com>
Date:   Tue, 5 Jan 2021 10:43:48 -0800
Message-ID: <CABBYNZL87cMLjEZOeVM+dmdh8noVgxN3hQBzKosKYKRjOEQm8Q@mail.gmail.com>
Subject: Re: [Bluez,v4,1/4] shared/mgmt: Add supports of parsing mgmt tlv list
To:     "linux-bluetooth@vger.kernel.org" <linux-bluetooth@vger.kernel.org>
Cc:     Yun-hao Chung <howardchung@google.com>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Hi Howard,

On Mon, Jan 4, 2021 at 8:22 PM <bluez.test.bot@gmail.com> wrote:
>
> This is automated email and please do not reply to this email!
>
> Dear submitter,
>
> Thank you for submitting the patches to the linux bluetooth mailing list.
> This is a CI test results with your patch series:
> PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=409009
>
> ---Test result---
>
> ##############################
> Test: CheckPatch - FAIL
> Output:
> btmgmt: Add command set-sysconfig
> WARNING:NAKED_SSCANF: unchecked sscanf return value
> #42: FILE: tools/btmgmt.c:1817:
> +               if (!sscanf(input + i * 2, "%2hhx", &value[i]))
> +                       return false;
>
> - total: 0 errors, 1 warnings, 121 lines checked
>
> NOTE: For some of the reported defects, checkpatch may be able to
>       mechanically convert to the typical style using --fix or --fix-inplace.
>
> "[PATCH] btmgmt: Add command set-sysconfig" has style problems, please review.
>
> NOTE: Ignored message types: COMMIT_MESSAGE COMPLEX_MACRO CONST_STRUCT FILE_PATH_CHANGES MISSING_SIGN_OFF PREFER_PACKED SPLIT_STRING SSCANF_TO_KSTRTO
>
> NOTE: If any of the errors are false positives, please report
>       them to the maintainer, see CHECKPATCH in MAINTAINERS.
>
>
> ##############################
> Test: CheckGitLint - PASS
>
> ##############################
> Test: CheckBuild - PASS
>
> ##############################
> Test: MakeCheck - PASS
>
>
>
> ---
> Regards,
> Linux Bluetooth

Applied, thanks.

-- 
Luiz Augusto von Dentz