Received-SPF: pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20201222124651.101063-1-marcel@holtmann.org> <CANFp7mV8RpF8gkrEbyA8ZOP1YH5CH0xkJeyPcaetROsqHiZWWg@mail.gmail.com>
In-Reply-To: <CANFp7mV8RpF8gkrEbyA8ZOP1YH5CH0xkJeyPcaetROsqHiZWWg@mail.gmail.com>
From:   Luiz Augusto von Dentz <luiz.dentz@gmail.com>
Date:   Mon, 11 Jan 2021 13:55:00 -0800
Message-ID: <CABBYNZJ7ednKQfBG+Ky+39+d2qO3YvXGn7TTvm-3SZ-uSNcsfA@mail.gmail.com>
Subject: Re: [PATCH] doc/mgmt-api.txt: Introduce Set Runtime Firmware command
To:     Abhishek Pandit-Subedi <abhishekpandit@chromium.org>
Cc:     Marcel Holtmann <marcel@holtmann.org>,
        Bluez mailing list <linux-bluetooth@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Hi Abhishek,

On Mon, Jan 11, 2021 at 11:38 AM Abhishek Pandit-Subedi
<abhishekpandit@chromium.org> wrote:
>
> Hi Marcel,
>
> I don't think this solves the original problem we were talking about:
> the driver should replace the runtime firmware on reload if it doesn't
> match what's on disk.
>
> Some background for the mailing list:
> - On a ChromeOS laptop, we discovered that the Bluetooth controller
> wasn't being fully powered down in some reboots. As a result, a new
> firmware wasn't being applied after an update.
> - The kernel driver was checking if the bluetooth controller had
> loaded some firmware already. If it was in bootloader mode, it would
> download new firmware. If it was not, it would skip downloading new
> firmware.
>
> The useful part of this mgmt command is to force the driver to reset
> to bootloader (Action = 0 in Set Runtime Firmware). However, without
> being able to compare the firmware version loaded on the controller,
> there's no clear signal for when this should be called. Loading the
> firmware through mgmt may be useful for debugging but you could also
> just replace the firmware on disk and "reset to bootloader" to achieve
> the same effect. I would actually expect unloading and reloading the
> module should do that.
>
> Also, moving the firmware loading from the driver to the userspace
> seems odd to me. Since the comparison is between the controller
> firmware and disk firmware, there's not much extra that the userspace
> knows that the kernel does not.

My last suggestion was just to have a MGMT command suggesting the
kernel to load the firmware from a different location, this could be
useful for testing purpose so one can set for example an old/beta
firmware to compare for regressions or test new features that
otherwise would not be available. That said perhaps we don't actually
need a new MGMT command for doing this and just by replacing the
current file would trigger a reload but that may get tricky when if
the location does get unmonted/remounted etc.

>
> ----
>
> Coming back to the original problem of when to reload runtime
> firmware, here are the conditions under which we do and don't want a
> reload.
>
> Do want a reload:
> - Reboot
> - Module is unloaded and reloaded
>
> Don't want a reload:
> - Transport disconnection (i.e. usb disconnect; some laptops will
> power down USB during suspend to save additional power but BT will
> stay powered up)

Well if the device disappears from the host I'm not really sure how
you will be able to detect that the firmware was retained, that said
when the adapter is power up again it should be possible to query it
what firmware it is currently running and then compare with the one
from file before attempting to load it, this should also work
regardless of the underlying transport/bus so it would work regardless
of the driver in use.

> - Power toggle (bluetooth power off -> power on)
> - HCI reset
>
> Letting the kernel driver maintain some sort of table of previously
> configured devices might be a better option. We can put that table in
> the module's static memory space so that it doesn't get cleared on
> device disconnects. These should be useful for internally connected
> Bluetooth (which may not always power cycle between resets) and for
> which you may want to force reloads around reboot or module reload.
> Externally connected Bluetooth will power cycle once disconnected
> anyway so this is moot for them.

It is probably simpler to just query the controller what firmware it
has before uploading a new one otherwise this gets very platform
specific, besides I don't think we would be able to tell if the USB is
connected internally or not.

> Thanks,
> Abhishek
>
> On Tue, Dec 22, 2020 at 4:47 AM Marcel Holtmann <marcel@holtmann.org> wrote:
> >
> > ---
> >  doc/mgmt-api.txt | 86 ++++++++++++++++++++++++++++++++++++++++++++++++
> >  1 file changed, 86 insertions(+)
> >
> > diff --git a/doc/mgmt-api.txt b/doc/mgmt-api.txt
> > index 1736ef009e75..47686ae32629 100644
> > --- a/doc/mgmt-api.txt
> > +++ b/doc/mgmt-api.txt
> > @@ -2187,6 +2187,7 @@ Read Controller Configuration Information Command
> >
> >                 0       External configuration
> >                 1       Bluetooth public address configuration
> > +               2       Runtime firmware configuration
> >
> >         It is valid to call this command on controllers that do not
> >         require any configuration. It is possible that a fully configured
> > @@ -3132,6 +3133,10 @@ Read Controller Capabilities Command
> >                 0x02            Max Encryption Key Size (BR/EDR)
> >                 0x03            Max Encryption Key Size (LE)
> >                 0x04            Supported Tx Power (LE)
> > +               0x05            Complete firmware name
> > +               0x06            Shortened firmware name
> > +               0x07            Firmware info string
> > +               0x08            Hardware info string
> >
> >         Flags (data type 0x01)
> >
> > @@ -3155,6 +3160,23 @@ Read Controller Capabilities Command
> >                 field is not available, it indicates that the LE Read
> >                 Transmit Power HCI command was not available.
> >
> > +       Firmware name (date types 0x05 and 0x06)
> > +
> > +               Only one of these will be present if the device is loading
> > +               some sort of runtime firmware. Only in the firwmare name
> > +               happens to exceed the 255 charaters, the shortened type
> > +               shall be used.
> > +
> > +               This value represents the driver chosen default firmware
> > +               for a controller. In case it is changed via Set Runtime
> > +               Firmware command that change will not be reflected here.
> > +
> > +       Firmware and hardware info (data types 0x07 and 0x08)
> > +
> > +               When provided by the hardware and the driver, these fields
> > +               will contain string of the firmware or the hardware for
> > +               debug or indentification purposes.
> > +
> >         This command generates a Command Complete event on success or
> >         a Command Status event on failure.
> >
> > @@ -3852,6 +3874,70 @@ Add Advertisement Patterns Monitor With RSSI Threshold Command
> >                                 Invalid Parameters
> >
> >
> > +Set Runtime Firmware Command
> > +============================
> > +
> > +       Command Code:           0x0057
> > +       Controller Index:       <controller id>
> > +       Command Parameters:     Action (1 Octet)
> > +                               Firmware_Length (2 Octets)
> > +                               Firmware (0-65535 Octets)
> > +       Return Parameters:      Missing_Options (4 Octets)
> > +
> > +       This command allows configuration of runtime firmware or patch
> > +       download setting. Since a vendor specific procedure is required,
> > +       this command might not be supported by all controllers.
> > +
> > +       Possible values for the Action parameter:
> > +               0       Reset to default driver firmware
> > +               1       Reset to current or configure new firmware
> > +
> > +       When resetting to the default firmware, Firmware_Length shall be
> > +       set to 0. The system will go back to the original firmware selected
> > +       by the driver. When resetting to current firmware, Firmware_Length
> > +       shall also be set to 0. If there has been never specified a new
> > +       firmware, then a reset to default or current is not different.
> > +
> > +       Loading a new firmware can be triggered with the Action 1 and a
> > +       Firmware specified. The Firmware is a string that would also be
> > +       used in request_firmware() and has to be NUL terminated. The
> > +       Firmware_Length field shall include the string length plus the
> > +       additional NUL byte.
> > +
> > +       In the case a driver has no default driver firmware, then an
> > +       Action 0 will fully reset the device into an unconfigured state.
> > +
> > +       When the support for runtime firwmare configuration is indicated
> > +       in the supported options mask, then this command can be used to
> > +       set the runtime firmware.
> > +
> > +       It is only possible to configure the runtime firmware when the
> > +       controller is powered off.
> > +
> > +       For an unconfigured controller and when Missing_Options returns
> > +       an empty mask, this means that a Index Added event for the now
> > +       fully configured controller can be expected.
> > +
> > +       For a fully configured controller, the current controller index
> > +       will become invalid and an Unconfigured Index Removed event will
> > +       be sent. Once the firmware has been successfully loaded an Index
> > +       Added event will be sent. There is no guarantee that the controller
> > +       index stays the same.
> > +
> > +       All previous configured parameters and settings are lost when
> > +       this command succeeds. The controller has to be treated as new
> > +       one. Use this command for a fully configured controller only when
> > +       you really know what you are doing.
> > +
> > +       This command generates a Command Complete event on success or a
> > +       Command Status event on failure.
> > +
> > +       Possible errors:        Rejected
> > +                               Not Supported
> > +                               Invalid Parameters
> > +                               Invalid Index
> > +
> > +
> >  Command Complete Event
> >  ======================
> >
> > --
> > 2.29.2
> >


-- 
Luiz Augusto von Dentz