Received: by 2002:a05:6a10:2785:0:0:0:0 with SMTP id ia5csp319062pxb; Wed, 13 Jan 2021 04:37:07 -0800 (PST) X-Google-Smtp-Source: ABdhPJzGLSoE9EtkMyYOd9tLo89ap8RN67z0twMYlbMh9apyKHrx8cbigQLFK5nquGpUcQ5PG0Zu X-Received: by 2002:a50:ab51:: with SMTP id t17mr1605827edc.89.1610541427226; Wed, 13 Jan 2021 04:37:07 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1610541427; cv=none; d=google.com; s=arc-20160816; b=F1+9ki9k4boIoIai/bqT4vUs2Fe0Gas+yD5H0q4mjIWbadf8hPFvJGn9SrsILq+iZK DQ8AnYxEZX+OFQRC8SEbJn7tGf6V2Dp/OUCbo3Dgn2+csC1dqwGIrKNrrLfzpMf5cD9y asD59gI4/AEwmWlLPqhvQ/YpdFMY2jeNdW8NfXOgCsL/vJ+7I654YBx0hoCLUWGpinHk pRSr0oud7c/e5wZamCRBd2ZCBAiV1mVxlnzT1pL6G46oMG9LprbjUbWOL6CVxqCPVLAK GTzywVG3AsofcfI7G/MwzjAxBcOO4IAuSKuRXvhGiAlSMV0eFAPhvvCBzKcPxXp486Hi N26A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:date:cc:to:from:subject :message-id; bh=WudzxwdCx97dWasBPREUVh4xP4yD5dkfpcwAy4Omf9Y=; b=LeyD8DGYKrewbCou2a4rncdNtmc/Tly9p5IlsCm0K5WupNt0VtsRdIOygmyAFEAk62 sN4QQRjK7WJ2W38Eh4pyj4pSjdNoUt2IrVvQGTdRzr6TQXHR9Tt/RltSRi/Y5eoDg1hm RQO3FNFpCBCaVUie+VwhK//hL8UQt2Fso+XAJKxw5ARJaqGkvc8Sk0PP0p+W18Dwqw1I uFypVzmMFCEr3fLIPACy0FpaZUcXgvdKWtHl0OlTByser2B+utPBH0a8iRXBmPqRRdsv pjMbQyAbM3J+Zwmb246Jsn6nEX2i+unBVOqEep2mNOgC9qMbVtursRTyKugpdPK4GfE0 P0HA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-bluetooth-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id gs8si825510ejc.79.2021.01.13.04.36.27; Wed, 13 Jan 2021 04:37:07 -0800 (PST) Received-SPF: pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-bluetooth-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726459AbhAMMdU (ORCPT + 99 others); Wed, 13 Jan 2021 07:33:20 -0500 Received: from relay7-d.mail.gandi.net ([217.70.183.200]:33241 "EHLO relay7-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725774AbhAMMdU (ORCPT ); Wed, 13 Jan 2021 07:33:20 -0500 X-Originating-IP: 82.255.60.242 Received: from [192.168.1.150] (lns-bzn-39-82-255-60-242.adsl.proxad.net [82.255.60.242]) (Authenticated sender: hadess@hadess.net) by relay7-d.mail.gandi.net (Postfix) with ESMTPSA id 98C3120010; Wed, 13 Jan 2021 12:32:38 +0000 (UTC) Message-ID: <76108887c222f10900df58da1468144ea9ad938d.camel@hadess.net> Subject: Re: [PATCH] Bluetooth: L2CAP: Try harder to accept device not knowing options From: Bastien Nocera To: Luiz Augusto von Dentz Cc: "linux-bluetooth@vger.kernel.org" , Florian Dollinger Date: Wed, 13 Jan 2021 13:32:37 +0100 In-Reply-To: References: <20201208172912.4352-1-hadess@hadess.net> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.38.2 (3.38.2-1.fc33) MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-bluetooth@vger.kernel.org On Thu, 2021-01-07 at 17:29 -0800, Luiz Augusto von Dentz wrote: > Hi, > > On Tue, Dec 8, 2020 at 9:36 AM Bastien Nocera > wrote: > > > > The current implementation of L2CAP options negotiation will > > continue > > the negotiation when a device responds with L2CAP_CONF_UNACCEPT > > ("unaccepted > > options"), but not when the device replies with L2CAP_CONF_UNKNOWN > > ("unknown > > options"). > > > > Trying to continue the negotiation without ERTM support will allow > > Bluetooth-capable XBox One controllers (notably models 1708 and > > 1797) > > to connect. > > Reviewed-by: Luiz Augusto Von Dentz Marcel? Anything else that would need to be done to land this? Cheers