Received-SPF: pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   bugzilla-daemon@bugzilla.kernel.org
To:     linux-bluetooth@vger.kernel.org
Subject: [Bug 210681] kernel: Bluetooth: hci0: don't support firmware rome
 0x31010000
Date:   Tue, 26 Jan 2021 16:52:13 +0000
Message-ID: <bug-210681-62941-Rlhe1XFZQh@https.bugzilla.kernel.org/>
In-Reply-To: <bug-210681-62941@https.bugzilla.kernel.org/>
References: <bug-210681-62941@https.bugzilla.kernel.org/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8BIT
Auto-Submitted: auto-generated
MIME-Version: 1.0
Precedence: bulk

https://bugzilla.kernel.org/show_bug.cgi?id=210681

Moreno G (moreno.giussani@protonmail.com) changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |moreno.giussani@protonmail.
                   |                            |com

--- Comment #22 from Moreno G (moreno.giussani@protonmail.com) ---
Created attachment 294865
  --> https://bugzilla.kernel.org/attachment.cgi?id=294865&action=edit
fix hci0: warn only if high rome

(In reply to Bradley Jarvis from comment #10)
> Created attachment 294393 [details]
> fix hci0: don't support firmware rome error
> 
> Avoid returning error code when bluetooth version match is not made from
> qca_devices_table and version high is set.
> 
> This reverts an error check that was removed to support WCN6855 which does
> have the high version set. The fix is to move the check after the table is
> scanned and no version match is made.
> 
> This fix will still produce the error message for example (for ATK3K
> 13d3:3402 IMC Networks Bluetooth USB Host Controller)
> 
> Bluetooth: hci0: don't support firmware rome 0x1020200
> 
> But the bluetooth hardware still works as it used to

Like Bradley Jarvis' fix, but it won't produce an error message but a warning
message for a possible incompatibility. Reverted the "don't care" comments for
other high ROM versions. Just my 2 cents

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are the assignee for the bug.