Received-SPF: pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210202034005.27697-1-hj.tedd.an@gmail.com> <6018d01f.1c69fb81.45e86.488c@mx.google.com>
In-Reply-To: <6018d01f.1c69fb81.45e86.488c@mx.google.com>
From:   Luiz Augusto von Dentz <luiz.dentz@gmail.com>
Date:   Wed, 3 Feb 2021 11:08:56 -0800
Message-ID: <CABBYNZLybQhs1Atm1KfUk7+OMxKv=z9hLTL3WFzCddDEWcNp=A@mail.gmail.com>
Subject: Re: [BlueZ,v4,1/2] tools/bluemoon: Display FW version of firmware file
To:     "linux-bluetooth@vger.kernel.org" <linux-bluetooth@vger.kernel.org>
Cc:     hj.tedd.an@gmail.com
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Hi Tedd,

On Mon, Feb 1, 2021 at 8:14 PM <bluez.test.bot@gmail.com> wrote:
>
> This is automated email and please do not reply to this email!
>
> Dear submitter,
>
> Thank you for submitting the patches to the linux bluetooth mailing list.
> This is a CI test results with your patch series:
> PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=425781
>
> ---Test result---
>
> ##############################
> Test: CheckPatch - FAIL
> Output:
> tools/bluemoon: Add support for checking other firmware file types
> WARNING:PREFER_DEFINED_ATTRIBUTE_MACRO: Prefer __packed over __attribute__((packed))
> #59: FILE: tools/bluemoon.c:757:
> +} __attribute__ ((packed));
>
> - total: 0 errors, 1 warnings, 168 lines checked
>
> NOTE: For some of the reported defects, checkpatch may be able to
>       mechanically convert to the typical style using --fix or --fix-inplace.
>
> "[PATCH] tools/bluemoon: Add support for checking other firmware file" has style problems, please review.
>
> NOTE: Ignored message types: COMMIT_MESSAGE COMPLEX_MACRO CONST_STRUCT FILE_PATH_CHANGES MISSING_SIGN_OFF PREFER_PACKED SPLIT_STRING SSCANF_TO_KSTRTO
>
> NOTE: If any of the errors are false positives, please report
>       them to the maintainer, see CHECKPATCH in MAINTAINERS.
>
>
> ##############################
> Test: CheckGitLint - PASS
>
> ##############################
> Test: CheckBuild - PASS
>
> ##############################
> Test: MakeCheck - PASS
>
>
>
> ---
> Regards,
> Linux Bluetooth

Applied, thanks.

-- 
Luiz Augusto von Dentz