Received-SPF: pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Sat, 6 Feb 2021 16:56:53 +0100
From:   Sjoerd Simons <sjoerd@collabora.com>
To:     Marcel Holtmann <marcel@holtmann.org>
Cc:     Trent Piepho <tpiepho@gmail.com>,
        linux-bluetooth <linux-bluetooth@vger.kernel.org>,
        LKML <linux-kernel@vger.kernel.org>,
        Hilda Wu <hildawu@realtek.com>,
        Sathish Narasimman <sathish.narasimman@intel.com>,
        Chethan T N <chethan.tumkur.narayan@intel.com>,
        Hsin-Yu Chao <hychao@chromium.org>,
        Amit K Bag <amit.k.bag@intel.com>,
        Johan Hedberg <johan.hedberg@gmail.com>,
        Luiz Augusto von Dentz <luiz.dentz@gmail.com>,
        kernel@collabora.com
Subject: Re: [PATCH] Bluetooth: btusb: Always fallback to alt 1 for WBS
Message-ID: <YB68RUVLRGQKS+yH@dawn.lan>
References: <20201210012003.133000-1-tpiepho@gmail.com>
 <7ADF39E2-647E-49E2-9C5B-B0BF6A303B95@holtmann.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <7ADF39E2-647E-49E2-9C5B-B0BF6A303B95@holtmann.org>
Precedence: bulk

On Fri, Dec 18, 2020 at 10:23:08PM +0100, Marcel Holtmann wrote:
> Hi Trent,
> 
> > When alt mode 6 is not available, fallback to the kernel <= 5.7 behavior
> > of always using alt mode 1.
> > 
> > Prior to kernel 5.8, btusb would always use alt mode 1 for WBS (Wide
> > Band Speech aka mSBC aka transparent SCO).  In commit baac6276c0a9
> > ("Bluetooth: btusb: handle mSBC audio over USB Endpoints") this
> > was changed to use alt mode 6, which is the recommended mode in the
> > Bluetooth spec (Specifications of the Bluetooth System, v5.0, Vol 4.B
> > ?2.2.1).  However, many if not most BT USB adapters do not support alt
> > mode 6.  In fact, I have been unable to find any which do.

> patch has been applied to bluetooth-next tree.

For easier application to the stable tree(s) this should probably get:
  Fixes: baac6276c0a9 ("Bluetooth: btusb: handle mSBC audio over USB Endpoints")

In my testing this indeed fixes mSBC audio with both a Belkin (Broadcom
BCM20702A, 050d:065a) and an Intel Bluetooth (8087:0a2b) adapters.

  Tested-By: Sjoerd Simons <sjoerd@collabora.com>

Regards,
  Sjoerd