Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp3991426pxb; Mon, 8 Feb 2021 05:31:51 -0800 (PST) X-Google-Smtp-Source: ABdhPJxuPiR26ylI3M2PBI6LijfDcgBG0/tB6dyOLtAeTLKrr1Gh0o3Fmob8ZJQDvj46fWgoCfzs X-Received: by 2002:aa7:d790:: with SMTP id s16mr17173366edq.294.1612791111617; Mon, 08 Feb 2021 05:31:51 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1612791111; cv=none; d=google.com; s=arc-20160816; b=eVnBrRVCBqOVbYyznzcJKsvtJxJVPR/FNyUbsOY1vxGs7NToSHQFJoprhILOPDiHDu OVwfCocND7PzCCQgkxouSeVb4BDJvvqnzLqytZwiBi/4aUMhR+ws7MBmalAzHgisyOXo erbmRwdcsr73plfdIvs6x2WmIg5U0bxPdraNJYqFMQTu7dC1fzGyQskkVxcTV4EQo1fn OBeekFsh4o9fftAj4ukmTYCv0GsOb5WaCZJqehm1Epzd2RJM0OzJ5nrPFso9pyfmTYJq rScNla2tm+Xgz29+77SKkKZteYi699zV2EBTPDEjpAzoikVlCyUv5QrRa2vT8DtQx4bV wapg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:user-agent:message-id:in-reply-to :date:references:subject:cc:to:from:dmarc-filter:sender :dkim-signature; bh=fswM5y6W+PBXhZObXryia2PwKlc/w0gNTSrV11Ri0dA=; b=dr735XSTa9G7wYAMm2M/0fQZLESNz3d1MSxs6dp9b8UlXsmX/rlp//rDbr1t9fETQS WXBGIXoKXgqUOp5aKyxyGVsC/Dl+UqgZoJreDXoRlP0tyBDK9JYBT0bN+RxST8q2v1ar qKuHcA5iNsHeNg9NlUf23wK9Fy7JBy5QvITR2cNt+76CowsGsU8azStc2EjDW8pcIJXo mFpq9v1dC2yhf1SRD23sbWJ9CQ+0fGf/cznA9GJJq3TOTcXyMrrmPapPGfmLFXJUQhzA 9pTfAs7QLH6M40T+EaEHuZ0QhT7llE2pOjLnCsF4wQURv2PuQ6pW4m1bQk7HcCiK+lLt D6/Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@mg.codeaurora.org header.s=smtp header.b=kqke+oHn; spf=pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-bluetooth-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id r3si11074953edm.503.2021.02.08.05.31.10; Mon, 08 Feb 2021 05:31:51 -0800 (PST) Received-SPF: pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@mg.codeaurora.org header.s=smtp header.b=kqke+oHn; spf=pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-bluetooth-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230160AbhBHN2z (ORCPT + 99 others); Mon, 8 Feb 2021 08:28:55 -0500 Received: from so15.mailgun.net ([198.61.254.15]:25847 "EHLO so15.mailgun.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229759AbhBHN1A (ORCPT ); Mon, 8 Feb 2021 08:27:00 -0500 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1612790787; h=Content-Type: MIME-Version: Message-ID: In-Reply-To: Date: References: Subject: Cc: To: From: Sender; bh=fswM5y6W+PBXhZObXryia2PwKlc/w0gNTSrV11Ri0dA=; b=kqke+oHnDWvWxVXnJDybNfXtBgBJoJiF0x3voF3z/V9PKfYkKDaqxJ/K+2jcP6dxeGMDWJMT aCZxbzRRl6t2gW3jWB/+xM0SiJxbgQLjVwcrKuPnXXq4sWmqE0GV2yxWjsNiupUuHkE1r+RR aEIzyR/i6YqRGs2hPQ9X7hcCenY= X-Mailgun-Sending-Ip: 198.61.254.15 X-Mailgun-Sid: WyI2MTA3ZSIsICJsaW51eC1ibHVldG9vdGhAdmdlci5rZXJuZWwub3JnIiwgImJlOWU0YSJd Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n05.prod.us-west-2.postgun.com with SMTP id 60213bddd5a7a3baae448e61 (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Mon, 08 Feb 2021 13:25:49 GMT Sender: kvalo=codeaurora.org@mg.codeaurora.org Received: by smtp.codeaurora.org (Postfix, from userid 1001) id D00E2C43462; Mon, 8 Feb 2021 13:25:48 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-caf-mail-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=2.0 tests=ALL_TRUSTED,BAYES_00,SPF_FAIL, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from tynnyri.adurom.net (tynnyri.adurom.net [51.15.11.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: kvalo) by smtp.codeaurora.org (Postfix) with ESMTPSA id BC709C433CA; Mon, 8 Feb 2021 13:25:45 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org BC709C433CA Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=fail smtp.mailfrom=kvalo@codeaurora.org From: Kalle Valo To: Venkata Lakshmi Narayana Gubba Cc: marcel@holtmann.org, johan.hedberg@gmail.com, mka@chromium.org, linux-kernel@vger.kernel.org, linux-bluetooth@vger.kernel.org, hemantg@codeaurora.org, linux-arm-msm@vger.kernel.org, bgodavar@codeaurora.org, rjliao@codeaurora.org, hbandi@codeaurora.org, abhishekpandit@chromium.org Subject: Re: [PATCH v1] Bluetooth: hci_qca:Fixed issue during suspend References: <1612539436-8498-1-git-send-email-gubbaven@codeaurora.org> Date: Mon, 08 Feb 2021 15:25:42 +0200 In-Reply-To: <1612539436-8498-1-git-send-email-gubbaven@codeaurora.org> (Venkata Lakshmi Narayana Gubba's message of "Fri, 5 Feb 2021 21:07:16 +0530") Message-ID: <87k0rik7xl.fsf@tynnyri.adurom.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-bluetooth@vger.kernel.org Venkata Lakshmi Narayana Gubba writes: > If BT SoC is running with ROM FW then just return in > qca_suspend function as ROM FW does not support > in-band sleep. > > Fixes: 2be43abac5a8 ("Bluetooth: hci_qca: Wait for timeout during suspend") > Signed-off-by: Venkata Lakshmi Narayana Gubba This patch does not apply neither to v5.11-rc7 or v5.11-rc5. What tree did you use as the baseline? $ patch -p1 < raw patching file drivers/bluetooth/hci_qca.c Hunk #1 succeeded at 76 (offset -1 lines). Hunk #2 succeeded at 1662 (offset -3 lines). Hunk #3 succeeded at 1720 (offset -3 lines). Hunk #4 FAILED at 2107. 1 out of 4 hunks FAILED -- saving rejects to file drivers/bluetooth/hci_qca.c.rej $ git am -s -3 raw Applying: Bluetooth: hci_qca:Fixed issue during suspend error: sha1 information is lacking or useless (drivers/bluetooth/hci_qca.c). error: could not build fake ancestor Patch failed at 0001 Bluetooth: hci_qca:Fixed issue during suspend -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches