Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp27416pxb; Mon, 8 Feb 2021 14:09:47 -0800 (PST) X-Google-Smtp-Source: ABdhPJwK/tUlY9UDO0x+7nE19zfPtozr5GJn2WS5/2HQcDxYWkXG9LY5WOKJRx9p3qjTDTeOyZ0d X-Received: by 2002:a05:6402:3552:: with SMTP id f18mr19184194edd.111.1612822186965; Mon, 08 Feb 2021 14:09:46 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1612822186; cv=none; d=google.com; s=arc-20160816; b=sbZrtVRT6vPn8Za9YVDUGwwAuAPJAvN6UNevHevfERlkt+4ABP3Iugvsu4rTclqx5H nDhdewuMSeRbg+Z/00Wl69CCWolv9Dex4oCESuJ3ov1JnTZ8pkTHm02nM7k0pPSot62r tVQGSvXqHpVg3aLMHmf+6pg1mwC2zl9oVyp4iSpL1bSXirTMVRjzcMl34PiU7xK+R/p7 kuU+3jRQz1DSE3gca2w0dWmBWXGZ+axf1nptb8ZrDEp8kbgVWT+d5OBRIq5fIcSrhSyZ xhyLHeCv2UNSs+RYjj+OcpjCX9e4AmTpPoLbJZVwgGZbrwtJfuz2+UYZFbin0rtSu+tX AEsw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=ecHnXy/1wGj2MG7vl2nvsZCgQh4S5SlQOsVq0e9KTNA=; b=K+v1TMHEVKM1bZYsgSY3nJajfd+1eGL0uJ1Mmby6exrCn9XukrDPXSkd3vEOEqZfaM qo9DoKOc5TFFT5Uszztz11E1NrTpbrpUXEsR1chZy2eeOGFT/0oiOp1BilbzrKhwngzb HHkeawlTkajy+uAEcC89YADtU5/dQhU6/JPlvGU16Ad5Dpx6u15a692YVjlIA+AsuK// K9krw9xpxWUUoNLfV4OyjPDVKuRWhOJwSojRQ7s+dHJL9EKr/fYg2Ynig+M7rQXaDlJS S9otTDVNYdvqZWrQqfBYqpGeS7mMbleHlARpYdmUAsfmTUw3cT9J02/XjT311CNgES6c yBSA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=dYWy5eSz; spf=pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-bluetooth-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id m18si12071158ejx.487.2021.02.08.14.08.30; Mon, 08 Feb 2021 14:09:46 -0800 (PST) Received-SPF: pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=dYWy5eSz; spf=pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-bluetooth-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229691AbhBHWGR (ORCPT + 99 others); Mon, 8 Feb 2021 17:06:17 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56340 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229637AbhBHWGQ (ORCPT ); Mon, 8 Feb 2021 17:06:16 -0500 Received: from mail-lf1-x131.google.com (mail-lf1-x131.google.com [IPv6:2a00:1450:4864:20::131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 28000C061786 for ; Mon, 8 Feb 2021 14:05:36 -0800 (PST) Received: by mail-lf1-x131.google.com with SMTP id w36so11401868lfu.4 for ; Mon, 08 Feb 2021 14:05:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=ecHnXy/1wGj2MG7vl2nvsZCgQh4S5SlQOsVq0e9KTNA=; b=dYWy5eSzfzpGnj3YEpyMGhZ90mS4/xQ8tSzTgLjD0c9YR/SUBkh+hxrKhhvwO++fqZ QIUv8o8D350ZbUjRDtq8y8N5UdsZKy/aYtxXU/RGOKwL2mle14Z5gdKSno6ZfyTz9CWs SRpGRFBoNddA900dD609IFI5zABc++m4Zqizf0WaNvTaqWXYDcbNBd19L7gBUor9QqDj rvzgbySiNL5Y2yKqrdzDIX5jevtUF7VwHVSGKGRdpaTFErX7Vl1hnTfJw+ns+1HAWlo+ znrOtXTULR+rSrNY3JgSUz4Jjc+bKReL45lBsWoDDxo4VP+cmAZyxfs901Ib3Dks4BGe TQNQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=ecHnXy/1wGj2MG7vl2nvsZCgQh4S5SlQOsVq0e9KTNA=; b=JMG1svjgDP9tjUVB8ODjoys70AsuLN8FXhptDCE3pLImvVaEDSDIp0UbCSoncTtAzN j7Q9LTdMDxOHMTiwIoWq0Aa8ANPkw5TE9F8CNKzo21/UnhFUm/HvDxjQUmcMlTLfRypD P7nUEMcAKZpv53KxM2tZiamfqtCqqmi1ua07jleTTrphy4BW+r9yOBPso0q5pOwBdVz9 pLD2506XMkXhJhiUq+Af5i7/pPWhr8U0Zuno4VeBWbQLHm9AbVWsQcJ35989WEaVGOMO /R2SLG34mD/DZ+BtFRKEZ3XoSfJqDaukMxAdwgNdhBY7N83wfyD/UF+es57pF17anLW7 AP5Q== X-Gm-Message-State: AOAM530xnOzpMlNL+o9YzD1JJI7ZU1IeAqPQRU40xtTrxSU2Bh2nWWS1 GPGo2Pz4js28eJaLKSzzqt9uies9w1tli33of+8= X-Received: by 2002:a19:ad42:: with SMTP id s2mr11326424lfd.448.1612821934297; Mon, 08 Feb 2021 14:05:34 -0800 (PST) Received: from localhost.localdomain (dzqmct6w75s9d-569np-4.rev.dnainternet.fi. [2001:14bb:a3:5428:6a5b:cbfa:3fe7:5d5b]) by smtp.gmail.com with ESMTPSA id p15sm975615ljc.123.2021.02.08.14.05.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 08 Feb 2021 14:05:33 -0800 (PST) From: Matias Karhumaa To: linux-bluetooth@vger.kernel.org Cc: Marcel Holtmann , Johan Hedberg , Luiz Augusto von Dentz Subject: [PATCH v2 0/1] Bluetooth: Fix Just-Works re-pairing Date: Tue, 9 Feb 2021 00:05:30 +0200 Message-Id: <20210208220531.3471-1-matias.karhumaa@gmail.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-bluetooth@vger.kernel.org Hi maintainers, While updating our CI machines to 5.8 series kernel, we noticed some regression in how Bluetooth LE Just-Works pairing works. In case Linux acts as responder and another device tries to re-pair using Just-Works, pairing fails due to DHKey check failure. This appears to be regression from eed467b517e8 ("Bluetooth: fix passkey uninitialized when used"). Best regards, Matias Karhumaa v2: More detailed commit message, improved readability of if-clause. Matias Karhumaa (1): Bluetooth: Fix Just-Works re-pairing net/bluetooth/smp.c | 42 +++++++++++++----------------------------- 1 file changed, 13 insertions(+), 29 deletions(-) -- 2.25.1