Received-SPF: pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: aLCxZ1fuD6TQe/bMBTb34GiOBSEK7ab5mOeoF1QCV7aADFvojsKVWZfEoOA3WDwvOnB5860TyJ
 PnUxP0O0tioA==
IronPort-SDR: RtlkM6Pbr1gp4IKbRZxhLLE5y0AtzVXbLSAl938dkdWoBMLZfRMC31XrI/jX/Zjk5YSQLJZ9yQ
 wER/Qd1DG7eg==
Message-ID: <9e9b46f42acc828ab362ba7f85ec0850e2d65770.camel@linux.intel.com>
Subject: Re: [PATCH v8 1/6] Bluetooth: btintel: Check firmware version
 before download
From:   Tedd Ho-Jeong An <tedd.an@linux.intel.com>
To:     Luiz Augusto von Dentz <luiz.dentz@gmail.com>,
        linux-bluetooth@vger.kernel.org
Date:   Wed, 10 Feb 2021 23:32:52 -0800
In-Reply-To: <20210211010900.2326531-1-luiz.dentz@gmail.com>
References: <20210211010900.2326531-1-luiz.dentz@gmail.com>
Organization: Intel Corporation
Content-Type: text/plain; charset="UTF-8"
User-Agent: Evolution 3.36.5 (3.36.5-2.fc32) 
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi Luiz,

On Wed, 2021-02-10 at 17:08 -0800, Luiz Augusto von Dentz wrote:
> From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
> 
> This checks the firmware build number, week and year matches with
> repective version loaded and then skip the download process.
> 
> Signed-off-by: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
> ---
> v2: Add patch that mover checks for operational mode after the version
> checking.
> v3: Fix not checking for operation mode before using btintel_read_boot_params
> since some models depend on that to contruct the fw filename. Also attempt to
> cleanup duplicated code.
> v4: Fix forwarding -EALREADY when firmware has already been loaded.
> v5: Fix not advancing fw_ptr.
> v6: Fix btusb_setup_intel_new_get_fw_name error checking for ddc.
> v7: Disable version checking for WsP/SfP.
> v8: Really disables version checking for WsP/SfP.
> 
>  drivers/bluetooth/btintel.c   | 105 +++++++++++++++++++++++++++-------
>  drivers/bluetooth/btintel.h   |   5 +-
>  drivers/bluetooth/btusb.c     |  18 +++++-
>  drivers/bluetooth/hci_intel.c |   7 ++-
>  4 files changed, 109 insertions(+), 26 deletions(-)
> 

I tested with ThP and no issue found.
I also tested with WsP and fw loading fine and no upgrading as expected.

More devices will be tested. Stay tune.

Regards,
Tedd