Received-SPF: pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <f6764fe94d45ff9211674c5799b193d15385a056.camel@collabora.com>
In-Reply-To: <f6764fe94d45ff9211674c5799b193d15385a056.camel@collabora.com>
From:   Luiz Augusto von Dentz <luiz.dentz@gmail.com>
Date:   Thu, 4 Mar 2021 10:44:52 -0800
Message-ID: <CABBYNZLp9pOopbEfONc=oOh=ODFi55YzA6BKoN4ABuSzuZdPbw@mail.gmail.com>
Subject: Re: Bug caused by moving to BlueZ 5.56 (bytes stripped from HoG reports)
To:     =?UTF-8?Q?Ricardo_Ca=C3=B1uelo?= <ricardo.canuelo@collabora.com>
Cc:     "linux-bluetooth@vger.kernel.org" <linux-bluetooth@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Hi Ricardo,

On Thu, Mar 4, 2021 at 9:40 AM Ricardo Ca=C3=B1uelo
<ricardo.canuelo@collabora.com> wrote:
>
> Hi all,
>
> I discovered this fix https://github.com/bluez/bluez/commit/35a2c50 while
> debugging a fwupd plugin for a HoG device that implements its FW upgrade
> mechanism using vendor-specific HID reports (
> https://github.com/fwupd/fwupd/blob/master/plugins/pixart-rf/fu-pxi-devic=
e.c).
>
> Initially, the developers were using BlueZ versions prior to 5.56, which =
is the
> first release that includes that fix, so their code was written with that
> behavior in mind. After moving to 5.56 we found out it crashed and we nee=
ded to
> adapt the code to the proper report format. I think this is the kind of i=
ssues
> that Dean mentioned here
> https://marc.info/?l=3Dlinux-bluetooth&m=3D160590969013204&w=3D2
>
> Have there been any more reports like this? Is this expected to have a gr=
eater
> impact than initially thought?

Nope, you are the first one to report a problem with this change, so
chances are that what Dean stated probably still holds since the vast
majority of devices didn't care about the report ID. So I suppose the
following code shall take care of it or does it not?

https://github.com/fwupd/fwupd/blob/master/plugins/pixart-rf/fu-pxi-device.=
c#L170

--=20
Luiz Augusto von Dentz