Received-SPF: pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <f6764fe94d45ff9211674c5799b193d15385a056.camel@collabora.com>
 <CABBYNZLp9pOopbEfONc=oOh=ODFi55YzA6BKoN4ABuSzuZdPbw@mail.gmail.com> <8ede2f3e7593cbbd78e5aa4d3b28257a75e17b63.camel@collabora.com>
In-Reply-To: <8ede2f3e7593cbbd78e5aa4d3b28257a75e17b63.camel@collabora.com>
From:   Luiz Augusto von Dentz <luiz.dentz@gmail.com>
Date:   Thu, 4 Mar 2021 11:12:08 -0800
Message-ID: <CABBYNZ+hEgLHitH4zF6M2Qh2Rm29E8D3Qgkh5EQ27Sa91Wr=Tg@mail.gmail.com>
Subject: Re: Bug caused by moving to BlueZ 5.56 (bytes stripped from HoG reports)
To:     =?UTF-8?Q?Ricardo_Ca=C3=B1uelo?= <ricardo.canuelo@collabora.com>
Cc:     "linux-bluetooth@vger.kernel.org" <linux-bluetooth@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Hi Ricardo,

On Thu, Mar 4, 2021 at 10:57 AM Ricardo Ca=C3=B1uelo
<ricardo.canuelo@collabora.com> wrote:
>
> Hi Luiz
>
> On Thu, 2021-03-04 at 10:44 -0800, Luiz Augusto von Dentz wrote:
> > Nope, you are the first one to report a problem with this change, so
> > chances are that what Dean stated probably still holds since the vast
> > majority of devices didn't care about the report ID. So I suppose the
> > following code shall take care of it or does it not?
> >
> >
> https://github.com/fwupd/fwupd/blob/master/plugins/pixart-rf/fu-pxi-devic=
e.c#L170
> >
>
> Yes, that's how we're dealing with it for now. It's a quick fix, a more g=
eneral
> solution would be to detect the BlueZ version and parse the reports accor=
dingly.
> By the way, is there a way to query the version of the running daemon oth=
er than
> running it with '-v' and parsing the result?

Not really, we could possibly add a version over D-Bus but that
wouldn't help for 5.56 anyway.

> I just wanted to let you know that this can actually happen so you're rea=
dy for
> it, as there might be more code like this in other projects, although I d=
on't
> know how frequent it is for a device to use vendor-specific report IDs.
>
> Cheers,
> Ricardo
>


--=20
Luiz Augusto von Dentz