Received-SPF: pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210305235217.2382976-1-danielwinkler@google.com> <20210305155113.Bluez.v3.3.Ieb6522963e3f54b0d63dd88ed3ce24a8942ed73e@changeid>
In-Reply-To: <20210305155113.Bluez.v3.3.Ieb6522963e3f54b0d63dd88ed3ce24a8942ed73e@changeid>
From:   Luiz Augusto von Dentz <luiz.dentz@gmail.com>
Date:   Mon, 8 Mar 2021 10:36:02 -0800
Message-ID: <CABBYNZKeiHhiro2tryrku=3vjWMXuBsWfGvgnJB6Ka-7orf-Pw@mail.gmail.com>
Subject: Re: [Bluez PATCH v3 3/3] doc/advertising-api: Add adv
 SupportedFeatures to doc
To:     Daniel Winkler <danielwinkler@google.com>
Cc:     "linux-bluetooth@vger.kernel.org" <linux-bluetooth@vger.kernel.org>,
        ChromeOS Bluetooth Upstreaming 
        <chromeos-bluetooth-upstreaming@chromium.org>,
        Miao-chen Chou <mcchou@chromium.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Hi Daniel,

On Fri, Mar 5, 2021 at 3:59 PM Daniel Winkler <danielwinkler@google.com> wrote:
>
> Add supported features to advertising dbus api.
>
> Reviewed-by: Miao-chen Chou <mcchou@chromium.org>
> ---
>
> Changes in v3:
> - Rebased onto master
>
> Changes in v2:
> - Doc: Expect empty SupportedFeatures if no support available
>
>  doc/advertising-api.txt | 20 ++++++++++++++++++++
>  1 file changed, 20 insertions(+)
>
> diff --git a/doc/advertising-api.txt b/doc/advertising-api.txt
> index 541c57004..ba9eacaae 100644
> --- a/doc/advertising-api.txt
> +++ b/doc/advertising-api.txt
> @@ -235,6 +235,7 @@ Properties  byte ActiveInstances
>                                          "2M"
>                                          "Coded"
>
> +

Extra empty line.

>                 dict SupportedCapabilities [Experimental]
>
>                         Enumerates Advertising-related controller capabilities
> @@ -257,3 +258,22 @@ Properties byte ActiveInstances
>                                 int16 MaxTxPower
>
>                                         Max advertising tx power (dBm)
> +
> +
> +               array{string} SupportedFeatures [readonly, optional]

This shall probably be marked as experimental for now.

> +
> +                       List of supported platform features. If no features
> +                       are available on the platform, the SupportedFeatures
> +                       array will be empty.
> +
> +                       Possible values: "CanSetTxPower"
> +
> +                                               Indicates whether platform can
> +                                               specify tx power on each
> +                                               advertising instance.
> +
> +                                        "HardwareOffload"
> +
> +                                               Indicates whether multiple
> +                                               advertising will be offloaded
> +                                               to the controller.
> --
> 2.30.1.766.gb4fecdf3b7-goog
>


-- 
Luiz Augusto von Dentz