Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp2113918pxb; Mon, 8 Mar 2021 14:45:31 -0800 (PST) X-Google-Smtp-Source: ABdhPJznkGx9k5tjSu24tcxJayuAdaK4rtL/TTSkln81dJWxG5DxrANoK8IDG/RCXRfWv0JP71Wg X-Received: by 2002:a17:906:d9d1:: with SMTP id qk17mr17203533ejb.52.1615243530860; Mon, 08 Mar 2021 14:45:30 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1615243530; cv=none; d=google.com; s=arc-20160816; b=nk0xfL8G2Tw9PU7UmDNGPrgi3pMcnK2zunhKGqGYp1EByckfX47W6XXBJAhVffvr19 EuYoI0o0SOAMhhLI0zuHj8VdOk9d8tlV+2LWIpz6wcMsPI8+xRxnlqgYrN+EG9q+oISA 34eLF1Z1L+tbIxvRBZ4I3cFVmrhv1y0QIPg6vyt94Rz2Jj/v4848tu/pHNGAmqygq2UG HnWGnNMWmXTKAUw59J5T7+B5e3zjkZ1gBVrFU9GTZsJ3F5SGczdTLHSM5/OTuRsv/aTi nVQxK8Zo5BCUOw0Nm6kJXE6ubgZxC9FGTlcdRbZdAVUSH1YNxPPwF459Y8xIka25ujkq l1KA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:to:from:dkim-signature; bh=ZE6Pml5paV8vMbhak/UxbFx6LzmyL4qlgh6H3g+QwnU=; b=cN/FcR3Zqp0r5epPCnq9oSpQ6EQwqCydjFxbGFwmpENwl8d8e173hmo0EVn4GJGpiP CQBKGtGAJQ+tc1SlCoqrBjYi9NtAUKXSxgdSWSK0ps+1POh3hYyFmAAsvw7WxfejWYTE 5jNmfX4Zh+cll1nNXalUGsXj8EVPHdz6Z92tgexf0vzhjpbcyZOKp2Akgs/qAyGpxAW0 v+PPl2uIYk0uB6BUszUftT2mVinLmgt4DU7n+p1xyziCDLZ9fSqyZGAwVwv6zZYCiCdM sjImjHZro9Uxc5LYFY5RqAmK+qhM7f/QFLnb/3UvK6Yl9+QjIwbOsalt1BGa3fiQhePw U+Ww== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=OBoVGKkr; spf=pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-bluetooth-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id v24si1687772edy.221.2021.03.08.14.45.08; Mon, 08 Mar 2021 14:45:30 -0800 (PST) Received-SPF: pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=OBoVGKkr; spf=pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-bluetooth-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231301AbhCHWnC (ORCPT + 99 others); Mon, 8 Mar 2021 17:43:02 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51522 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230404AbhCHWma (ORCPT ); Mon, 8 Mar 2021 17:42:30 -0500 Received: from mail-pf1-x42b.google.com (mail-pf1-x42b.google.com [IPv6:2607:f8b0:4864:20::42b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5FCB7C06174A for ; Mon, 8 Mar 2021 14:42:30 -0800 (PST) Received: by mail-pf1-x42b.google.com with SMTP id m6so8202577pfk.1 for ; Mon, 08 Mar 2021 14:42:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:date:message-id:mime-version :content-transfer-encoding; bh=ZE6Pml5paV8vMbhak/UxbFx6LzmyL4qlgh6H3g+QwnU=; b=OBoVGKkr+L8E3jPfPlY7lUNSrEK5lDVroJpTMit/xH79JJvxC79WfLx7Qo90IX19Tm WD39jjM6qWKcmyX6+FDyb1lzcatwWt89b60nIgE0/ktcCm4XKdoABgBh5eogwKZjT0fp LXlu7MOpFSF2dJXJRpE3cueYA1GAoeVTb91YQxUqDRIZvhcOskONcJzzMBmu06nRwgy7 Wd/L+Qz1KQMl640o4eZ41hHLjiWcE8KR2g5fnZDoGh22ruf0rRQXbft3OKwhWy61YQ0n 2EB6PUzXv8w0psA27Qth4EpOyW53lfchiFGJOD2YEtD0DGoBdyofvjYLPp1g7dxY42Gd V3RA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:mime-version :content-transfer-encoding; bh=ZE6Pml5paV8vMbhak/UxbFx6LzmyL4qlgh6H3g+QwnU=; b=cMiqr60s4fgLX4qfm75Kt98+dtwJlEkKClQTeoDRncex8Cs9HlnUaTEsFfwglbXNZE odEKDQrBuplBNOpnKeFagQ31IjarS7P3rtCuRFmFVT1uPO9i/5Mg0nJSq15w1lLa6uJu fuvtf70AYf66ZScVnZOH7rcMNPf/a0p4a51l5KW8ifQ/nXDIlxH8EMogcFrMZDlYV+16 lDuDqrs4cNEhl29iP9+yrOzrWLER4p0HcfLVvkBiawa7PNJIoaBwa/bCHlG0H7A5vvlv FFh1FiFBHLfu3Fh32ZBs2dIOgTj39Udh/apHsAVYuAC74IHFs698M+qZIQ4SDsTE2XK5 7s3A== X-Gm-Message-State: AOAM533lhF+jRXWMESf/SiiqjTOG8QesUmlwqXfmh6ETctiSovfVjE58 IMM/bgw70pXiLafNnmkmweAzF1IOJ84e0g== X-Received: by 2002:a63:c47:: with SMTP id 7mr14626488pgm.300.1615243349710; Mon, 08 Mar 2021 14:42:29 -0800 (PST) Received: from lvondent-mobl4.intel.com (c-71-56-157-77.hsd1.or.comcast.net. [71.56.157.77]) by smtp.gmail.com with ESMTPSA id j2sm10879563pgh.39.2021.03.08.14.42.29 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 08 Mar 2021 14:42:29 -0800 (PST) From: Luiz Augusto von Dentz To: linux-bluetooth@vger.kernel.org Subject: [PATCH v2] monitor: Fix invalid access Date: Mon, 8 Mar 2021 14:42:28 -0800 Message-Id: <20210308224228.344888-1-luiz.dentz@gmail.com> X-Mailer: git-send-email 2.29.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-bluetooth@vger.kernel.org From: Luiz Augusto von Dentz ident can be NULL when printing user logs which may lead ot invalid access. Fixes: https://github.com/bluez/bluez/issues/92 --- monitor/packet.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/monitor/packet.c b/monitor/packet.c index a72b424fe..8b87d3d8b 100644 --- a/monitor/packet.c +++ b/monitor/packet.c @@ -11306,7 +11306,7 @@ void packet_user_logging(struct timeval *tv, struct ucred *cred, label = "Message"; } - if (ident[0] == '<' || ident[0] == '>') { + if (ident && (ident[0] == '<' || ident[0] == '>')) { packet_decode(tv, cred, ident[0], index, color, label == ident ? &ident[2] : label, data, size); -- 2.29.2