Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp1175477pxf; Fri, 12 Mar 2021 03:53:06 -0800 (PST) X-Google-Smtp-Source: ABdhPJxYdsNi2eYtvQ4jXmmEX9jgtJAri1D9R2fKmSzjEgLZSVX8Xhw5qBoqyh9WM3FxpXIR5jkH X-Received: by 2002:a17:906:c1ca:: with SMTP id bw10mr8171749ejb.510.1615549986519; Fri, 12 Mar 2021 03:53:06 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1615549986; cv=none; d=google.com; s=arc-20160816; b=PBV9CX2n6fn74QRsxwoFB1mIitT2edY4FN2eDsh9ta2JIVAVpYZgI2+oXPn9id9HMd /Dee9Q9lnw3Ua3IMmaZNrUj6AkuEivm/dW/vnWH1qUAPIufgwlxjssaO5VWoXRoaxWrh jIS9Nsp5N7VTv78rFiqTFqn7/qkijW9feZF+RrV8V4g5r/Fgv4hRQYas14SF8c6T4N1T USVYv2D3VmOaISg9lvZC7nObHdgmX/WjaEoL2HK2SzzYHl5b+aWmN3DyTKJ23bBBCtVL oggOatnifMlwmcMxajtB0QCIxLB4yWwMba8vPn6WkMUFHjATnrnN3V0PD2q8QDpVxqop anbQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:to:from; bh=QjzAm1fpFr0IxLpSnj8e/11c5XqyLWVEHxZ6AnKJWDU=; b=1DQF9tVQ2GuGR09XN2pRkitDOe+eiBD1btUEmU3Y4N0zqyRUyJOoAZ/ivhQiCw/Ewf zkPkHRlWVd+uOsj1fvR2gkce9xmys9Hj8ZOzSHRQOQSXvvS7esndkia8hnCA875UPFSn o33N5E2xyRQB7YU5kAiBzi0lm+2wtHqGqngYGI22VppNMY34KyyQjd5iPilpVEEp0y7D 581zq2YrBr/f+PT9eTqmtrKL7VU3X9YzqdI5KsQ8acN/Ge3nVCIQfuHfDv4lHEAL5WtC 3TouYYKOqFtPOe5VvR6ZHahoKgwZt4iBpacvr0yGdYPxfy9UkgzETSWV+gO8sQkfg73J o8jg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-bluetooth-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=collabora.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id vr7si3888105ejb.392.2021.03.12.03.52.28; Fri, 12 Mar 2021 03:53:06 -0800 (PST) Received-SPF: pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-bluetooth-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=collabora.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233170AbhCLKwj (ORCPT + 99 others); Fri, 12 Mar 2021 05:52:39 -0500 Received: from bhuna.collabora.co.uk ([46.235.227.227]:52586 "EHLO bhuna.collabora.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233308AbhCLKwP (ORCPT ); Fri, 12 Mar 2021 05:52:15 -0500 Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: fdanis) with ESMTPSA id 8AC521F46C2A From: =?UTF-8?q?Fr=C3=A9d=C3=A9ric=20Danis?= To: linux-bluetooth@vger.kernel.org Subject: [PATCH BlueZ] adapter: Fix discovery trigger for 0 second delay Date: Fri, 12 Mar 2021 11:52:06 +0100 Message-Id: <20210312105206.22534-1-frederic.danis@collabora.com> X-Mailer: git-send-email 2.18.0 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-bluetooth@vger.kernel.org When calling `StartDiscovery` the effective start can take around 10 ms or up to 700 ms. g_timeout_add_seconds() call doesn't ensure the time for the first call of the timer if the delay is less or equal to 1 second. --- src/adapter.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/src/adapter.c b/src/adapter.c index cc0849f99..daa4c18b7 100644 --- a/src/adapter.c +++ b/src/adapter.c @@ -1797,6 +1797,12 @@ static void trigger_start_discovery(struct btd_adapter *adapter, guint delay) if (!btd_adapter_get_powered(adapter)) return; + if (!delay) { + adapter->discovery_idle_timeout = g_idle_add(start_discovery_timeout, + adapter); + return; + } + adapter->discovery_idle_timeout = g_timeout_add_seconds(delay, start_discovery_timeout, adapter); } -- 2.18.0