Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp1410245pxf; Fri, 12 Mar 2021 08:53:31 -0800 (PST) X-Google-Smtp-Source: ABdhPJyvBPOYI+XB6VOFj0MRQMGJmDmfDShdcYoqunPPAtBbX+jfRNoRFGVNQeG0L+jPnXecuYJn X-Received: by 2002:a17:906:789:: with SMTP id l9mr9403809ejc.161.1615568010888; Fri, 12 Mar 2021 08:53:30 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1615568010; cv=none; d=google.com; s=arc-20160816; b=v5laZ8tTFDG//5Noi+Dv4jcwmn4lOVlWD/r42sxFN5tqGJ9herrFpqTNyILf0M5od7 CYzZjNzFcD1TuOV/vORjf8kNQMGk/WL27IHjIDWTkvy8B9KTRiZ+tJgZtsY3N/hJhBml KAe15q2buePZffFeWce2sBA+dwuIeEs0tozyQYZ+2UK0PFXSQiUxLjK8tfq6SJ5Lricu n2eFRE01dF1xp4kj/qvhnVS4MRs/HWjCq7hl5PvR7ttJNLyxiPpBGNK2nQtrQRlPEMt5 TOwcpY1Xse/Lq4UO6vIToWKMxJTA4whYJHP+AUkpOUGTzAgfzF0CQK9Ib6xZa8jwfpOR MN0A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:to:from; bh=fme4QWBQnempRtOfCS/a62IngiNz6gkL3K309KMYSHM=; b=iMAEAOF8GSWbl2AgKS+emht3H1QrIT++EhHUS03Vs7O/Be/zM5GUZ3WCcT9lVF6H4l sHExyNjHQhkiyCvxKdyh89NtZ+LmAAiWBnF3wdjZwKphOlrHP9utw/gHkoyE4HM6a1C+ C9Npt5ahhgJ0mGwB1K8TE7C6sxvb6qHXTpiSOVS5dDffMeVKMdwz9VhUPyqxs0U+gtQU sTApy/eXGHQOVUn5ei3Rf9PhqoEXOF+T87jUFKOnjKSI3IYSX2aYCE8GxF1eYz43g02g Ns2FfypjzGimOoqdnU4ByXHGMoOjbyiVkPuzQDdsuob5z3y//595atcDEq9EUnq3/37j NBQw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-bluetooth-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=collabora.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id de53si4468703ejc.358.2021.03.12.08.52.51; Fri, 12 Mar 2021 08:53:30 -0800 (PST) Received-SPF: pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-bluetooth-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=collabora.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231670AbhCLQuk (ORCPT + 99 others); Fri, 12 Mar 2021 11:50:40 -0500 Received: from bhuna.collabora.co.uk ([46.235.227.227]:56426 "EHLO bhuna.collabora.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231597AbhCLQu2 (ORCPT ); Fri, 12 Mar 2021 11:50:28 -0500 Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: fdanis) with ESMTPSA id 17E8C1F46ECE From: =?UTF-8?q?Fr=C3=A9d=C3=A9ric=20Danis?= To: linux-bluetooth@vger.kernel.org Subject: [PATCH Bluez v2] adapter: Fix discovery trigger for 0 second delay Date: Fri, 12 Mar 2021 17:50:17 +0100 Message-Id: <20210312165017.31829-1-frederic.danis@collabora.com> X-Mailer: git-send-email 2.18.0 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-bluetooth@vger.kernel.org When calling `StartDiscovery` the effective start can take around 10 ms or up to 700 ms. g_timeout_add_seconds() call doesn't ensure the time for the first call of the timer if the delay is less or equal to 1 second. --- v2: Fix issue founs by CI src/adapter.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/src/adapter.c b/src/adapter.c index cc0849f99..3078ce1a8 100644 --- a/src/adapter.c +++ b/src/adapter.c @@ -1797,6 +1797,13 @@ static void trigger_start_discovery(struct btd_adapter *adapter, guint delay) if (!btd_adapter_get_powered(adapter)) return; + if (!delay) { + adapter->discovery_idle_timeout = g_idle_add( + start_discovery_timeout, + adapter); + return; + } + adapter->discovery_idle_timeout = g_timeout_add_seconds(delay, start_discovery_timeout, adapter); } -- 2.18.0