Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp2644364pxf; Sun, 14 Mar 2021 06:53:48 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyLriANUwuDHO5I3hXI+OZwA7fVst9Z9YGvIP4yatxKT+oY+NjWLKn/0aPA895sWM8n9W0H X-Received: by 2002:aa7:cf02:: with SMTP id a2mr24597704edy.59.1615730028664; Sun, 14 Mar 2021 06:53:48 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1615730028; cv=none; d=google.com; s=arc-20160816; b=RXCEuxz4AeTBw78VwmTQEKfQO49oT05penObcnVEDfM7O37fDjnQ0O+uLLbZbkWSZT N2N2Hm+71GfiPzTw93RQx2iE4F6mfRPYBOeMxuWGuxKiWl8P+VMG4/GFVdpl+esyGtYF Ep5F8ccjiGv8oxvgNVOGd9cMorpMBnRAPn7yUu41aIhRDc6XINpYVZDZpobOmk5Nbzof Vb4RBvK/jnWng0lPs1Q8VFaGnaXcffhOmM5QEEFULfW3ibCnHvj4lO+iHybpXSAhUocS DXLsNCdAebvX9Oj6Yyse81Vm0L6IYD6JX8Va/fV1B7hHhDzygF1mwR74CLG4NuhQW4Jw ETVw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:to:from; bh=+YXVFX+M8xt451b7GyWHDRcpS/FvXXzLPiO6JjXCXV0=; b=RbEKcJEzNlsXnSMd9n49ARNcqqkD5WsP/w5oOSbjdvPxHssG7RG8hy9mwGFLx4/r45 r5xD9/yXCB4dRIwhaavFiYsEy0m5vC636oUOWq8DcVLu/Yq/EnO/fQlK8SztBrBa/V9u eYvMMsEizF+Vsb5H1c96Ny15MMyhAvEWc4s6EKFTxWgxa3zoOByMRA06nihQivE3V2s9 nQmp0Qcwc+3Vfjz4UzERbL6xCgDKRhrEgyIYTNpJBqd/clzaqfDQAW7CGZQhi4T+PY+k W+SrU2zyimat9dVJlk/KiWuNR88UwfK4OBJ9NNUuODjge+6dASd1SROdmxpObrif9ihY Lb5g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-bluetooth-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id c26si9098304edn.447.2021.03.14.06.53.04; Sun, 14 Mar 2021 06:53:48 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-bluetooth-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230342AbhCNNuL (ORCPT + 99 others); Sun, 14 Mar 2021 09:50:11 -0400 Received: from coyote.holtmann.net ([212.227.132.17]:42696 "EHLO mail.holtmann.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229870AbhCNNto (ORCPT ); Sun, 14 Mar 2021 09:49:44 -0400 Received: from localhost.localdomain (p4fefc126.dip0.t-ipconnect.de [79.239.193.38]) by mail.holtmann.org (Postfix) with ESMTPSA id 44426CECA3 for ; Sun, 14 Mar 2021 14:57:19 +0100 (CET) From: Marcel Holtmann To: linux-bluetooth@vger.kernel.org Subject: [PATCH] Bluetooth: Fix mgmt status for LL Privacy experimental feature Date: Sun, 14 Mar 2021 14:49:38 +0100 Message-Id: <20210314134938.259601-1-marcel@holtmann.org> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-bluetooth@vger.kernel.org The return error when trying to change the setting when a controller is powered up, shall be MGMT_STATUS_REJECTED. However instead now the error MGMT_STATUS_NOT_POWERED is used which is exactly the opposite. Signed-off-by: Marcel Holtmann --- net/bluetooth/mgmt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/bluetooth/mgmt.c b/net/bluetooth/mgmt.c index 6b5bdf1f39ca..105d0743735d 100644 --- a/net/bluetooth/mgmt.c +++ b/net/bluetooth/mgmt.c @@ -3984,7 +3984,7 @@ static int set_exp_feature(struct sock *sk, struct hci_dev *hdev, if (hdev_is_powered(hdev)) return mgmt_cmd_status(sk, hdev->id, MGMT_OP_SET_EXP_FEATURE, - MGMT_STATUS_NOT_POWERED); + MGMT_STATUS_REJECTED); /* Parameters are limited to a single octet */ if (data_len != MGMT_SET_EXP_FEATURE_SIZE + 1) -- 2.30.2