Received-SPF: pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Content-Type: text/plain;
        charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.60.0.2.21\))
Subject: Re: [PATCH v2] Bluetooth: L2CAP: Fix not checking for maximum number
 of DCID
From:   Marcel Holtmann <marcel@holtmann.org>
In-Reply-To: <20210315200437.1800434-1-luiz.dentz@gmail.com>
Date:   Mon, 15 Mar 2021 21:09:19 +0100
Cc:     linux-bluetooth@vger.kernel.org
Content-Transfer-Encoding: 7bit
Message-Id: <0BE392E6-430C-4F29-8C6D-F1A9568FAA85@holtmann.org>
References: <20210315200437.1800434-1-luiz.dentz@gmail.com>
To:     Luiz Augusto von Dentz <luiz.dentz@gmail.com>
Precedence: bulk

Hi Luiz,

> When receiving L2CAP_CREDIT_BASED_CONNECTION_REQ the remote may request
> more channels than allowed by the spec (10 octecs = 5 CIDs) so this
> checks if the number of channels is bigger than the maximum allowed and
> respond with an error.
> 
> Signed-off-by: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
> ---
> v2: Respond with an error instead of truncating the response with maximum
> allowed nunber of channels.
> 
> include/net/bluetooth/l2cap.h |  1 +
> net/bluetooth/l2cap_core.c    | 12 +++++++++---
> 2 files changed, 10 insertions(+), 3 deletions(-)

patch has been applied to bluetooth-next tree.

Regards

Marcel