Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp4464660pxf; Tue, 16 Mar 2021 14:20:25 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxSqO6ESkAxigZojVxv2IYMQ3VKMdjY9jRQsBQo6x1viuuC3VCVfjgb0itZdxC+5gLgMPq9 X-Received: by 2002:a17:906:5918:: with SMTP id h24mr32427109ejq.501.1615929625557; Tue, 16 Mar 2021 14:20:25 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1615929625; cv=none; d=google.com; s=arc-20160816; b=LaZa/Vy7/9zT8bb8T0p5C5W8LTtTKZhRBnnZpVMtUzlFiQPkQgBhllIhMm2lFIDQ1U A/sl3YH7c/74qWw4g0JHiFJmM2Vr+gRIZDV7/KnQ3F5hE5fnSXNojl9N90ZYpLH0FnFC CBtAE6NzXKKB+p6O2nV/6UJm8eD5jmrQjcFCFe0FAOVfrT6KLg2B6ahh8ll2oNZvJ/1w w9dDIL0cv+Vydn3NC4KK87yMBzfhxwgSaglb1tY0+64BRyEY+Q3jHh8cGgwo9XYRX/t1 sqWWS8rDqBhNCR7c6ZE6c8Pkj0OJXGr/aXvWqPGU1G7zUTNiZJ8KKLhhnPnW/oFv6Yow VSRQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=Ix3DMj0wnR8fHsTcp+3g/uiSpEorFQ4dXAiWxlG70U8=; b=bcNKwKrB/GwOm5cNJzkmMycV3B7tTaLrK4zCulEF3xL38tAnbv8Cmv23kfPCoPwysu qG/g3IU+4fEs06esi0BeuQ94VIJd61qxFZV8MSgD+YLbOHEzkrnUzA8QpbewUNsBvV3Y gqeM9RUC96Tg0vH97SWEXHutXbllnP5knczIoNc3hIbjXOUENMmNq8hwB8bYRffmPNzU h1BaHV3vUa8ZyZ/uyHVdnlzRiBmauz3jZ5J3ckpCLXeIaFmL4F9VhVhlI9trnidKfV1Q +cw3utee2A+MgYZl4YLHPBq8juen6OZOHRbmDGsyGELmNjIrqBz0eU0a9DcEgQFlQnr4 L3hA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=oSxytHqy; spf=pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-bluetooth-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id hc40si13037604ejc.276.2021.03.16.14.19.39; Tue, 16 Mar 2021 14:20:25 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=oSxytHqy; spf=pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-bluetooth-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236436AbhCPSIo (ORCPT + 99 others); Tue, 16 Mar 2021 14:08:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42376 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239909AbhCPSHV (ORCPT ); Tue, 16 Mar 2021 14:07:21 -0400 Received: from mail-ot1-x32a.google.com (mail-ot1-x32a.google.com [IPv6:2607:f8b0:4864:20::32a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5ECB6C06175F for ; Tue, 16 Mar 2021 11:07:21 -0700 (PDT) Received: by mail-ot1-x32a.google.com with SMTP id w21-20020a9d63950000b02901ce7b8c45b4so7335274otk.5 for ; Tue, 16 Mar 2021 11:07:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Ix3DMj0wnR8fHsTcp+3g/uiSpEorFQ4dXAiWxlG70U8=; b=oSxytHqyMnaDAnT7TDo/Ml5ikEydcuFwk1xa1HiFJoy4tLnN/JBH4/te99H09KfX4m /tZbesM3+cErPpsLliPNchgsg1c9fctMFpjt4bPZwS00lJJ22BZYNU8V7yll3SUho7+s SlkWX5XsCsLpU2PoXdVXcXsjGWW7uFvIk/FzH3pKbitotwRzmUkPSuPEYZ5yyc1Pashm KlrZqyJAu2A5DiozUzHxOOh1m8mx3MWzrh/lF78bR8METkNAL8tr+UMc92xxLj9qNyRz KJBWos9bD6dRry8RGg/ifsxfxhvxM105XKJZi5kEdyOPU0P3vDP8DU0oEaA3nufIXg2j vTpw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Ix3DMj0wnR8fHsTcp+3g/uiSpEorFQ4dXAiWxlG70U8=; b=sKVr5TSzuClNRoZfBSfAvlyX/g6I6vZxNOAKcNKyULEm8zmGu/kNhEib3Sqb+fh2At vI7Ifh3P+iuuUszI5xu6gwgJ7Z6DvXf99w0XDgjG1uUQS3/b6avEXmtc/5hGrOQxePqf 9U1T6ynRLo8pT8DlAr3wpBBzi89SPOvReRRSeKxwygPMgkaDqh1PIshO+AkPwIgBhsWw XagpPU4xlHqbCZ8UrW4miH8jqUh3DeskbSPjHaWsswgOTTmR5tU+RPu39xceJhR2NliO l/2uWSBlGA47Ia6Mb0mmHezuB45D7SvcZrbuysPJKhPgA5KdfGnrdl+mUNPPrRnvouWB JnEw== X-Gm-Message-State: AOAM532WAS4hts69heVa0M8GlNIFRqun96ZdNxycMYvB/G9wFj0gKn7t DZKmP4Bl5G8D/gz8EU56KW/zPI/X2/9M3adwj4s= X-Received: by 2002:a05:6830:57:: with SMTP id d23mr54660otp.44.1615918040746; Tue, 16 Mar 2021 11:07:20 -0700 (PDT) MIME-Version: 1.0 References: <20210316105738.11560-1-ayush.garg@samsung.com> In-Reply-To: <20210316105738.11560-1-ayush.garg@samsung.com> From: Luiz Augusto von Dentz Date: Tue, 16 Mar 2021 11:07:09 -0700 Message-ID: Subject: Re: [PATCH BlueZ] btmgmt: Fix typo in printing Set PHY Configuration command error To: Ayush Garg Cc: "linux-bluetooth@vger.kernel.org" , Anupam Roy , nitin.j@samsung.com Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-bluetooth@vger.kernel.org Hi Ayush, On Tue, Mar 16, 2021 at 8:37 AM Ayush Garg wrote: > > Signed-off-by: Ayush Garg > --- > tools/btmgmt.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/btmgmt.c b/tools/btmgmt.c > index f4eb541fa..647c696f8 100644 > --- a/tools/btmgmt.c > +++ b/tools/btmgmt.c > @@ -4725,7 +4725,7 @@ static void cmd_phy(int argc, char **argv) > if (mgmt_send(mgmt, MGMT_OP_SET_PHY_CONFIGURATION, index, sizeof(cp), > &cp, set_phy_rsp, NULL, NULL) == 0) { > error("Unable to send %s cmd", > - mgmt_opstr(MGMT_OP_GET_PHY_CONFIGURATION)); > + mgmt_opstr(MGMT_OP_SET_PHY_CONFIGURATION)); > return bt_shell_noninteractive_quit(EXIT_FAILURE); > } > } > -- > 2.17.1 Applied, note that I changed the commit message a little bit and removed the Signed-off-by since we don't use that in userspace. -- Luiz Augusto von Dentz