Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp382326pxf; Wed, 24 Mar 2021 07:14:37 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzzkNVT9+8B/ecPDA2pr4tQFt5zdl+w1QWWTyc6qz9UVOUk41IzNbn0XqGUmF4O7GPbgz4c X-Received: by 2002:a05:6402:11c9:: with SMTP id j9mr3658695edw.348.1616595277524; Wed, 24 Mar 2021 07:14:37 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1616595277; cv=none; d=google.com; s=arc-20160816; b=e3JAjlWBvGXe1ectKmAQFiKZZtqhMB8sZzet1m3UG7M4G1WYB2ufbBcx+ByTRUgYvC i/65fOYmonHkmBplOmFMzdDRTHIIZCZhVNtIU/XFWQXpQ+EIt3pobcBQAMXDZ18X9Lcg sM4dDNjli1ZxKPRhbOqnIuDZ4iSCMxLeqkGsBATaq1YIdzmDdkW7FyGRIwbJSt+rH3St 95cu+e/01N4tW5j97dsCi3KS99jg2FYJv3Nh1QzG6cmn7y/OMz1qyy3fxRT0s96+7p9h zk7xH+SEoM/9D8GQVr6wkeXPwzX1RhDPBfFzqcqKkGT0KRjTwjGX4O0p2q3ADiD2a/u3 3HYg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:to:from; bh=8kXDVMfii3C3fxxTmZAa5j6a1iv63tNoOsJDgapHxHw=; b=idPvyEZxxe3C4SjfYxUwjbZ+RCobUWoZA3FtyeeTCckaMmdUFGhH0oy7l6pGcjat7o 52Rkl+0tNXARp0IHTCAUTZacEU9u50a+BIVuXSZY84JlKsRY5zOVnM4IBgZndHso5IYD iNUhPFomvHrc1Ap2a8kYXLcY51kwmAMn7Qsk7RlLKdka57HuCUTU547d53zWP85aOBVI gY84PHCmr2uKwv79UdgqsM2W5HEiXpHxH0ZdEOrBgGJEnqWLcxC1xnHag1wl+BPsxegP 3BtBmzTc7mNrpOkZrRA85mi5Frvx16F8YfcDyJUQ86cK0MzwZUcPkUbdDYFrla+Ahbon 7u3A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-bluetooth-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id x4si2050203edd.118.2021.03.24.07.13.44; Wed, 24 Mar 2021 07:14:37 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-bluetooth-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236049AbhCXOLZ (ORCPT + 99 others); Wed, 24 Mar 2021 10:11:25 -0400 Received: from coyote.holtmann.net ([212.227.132.17]:34323 "EHLO mail.holtmann.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236080AbhCXOLG (ORCPT ); Wed, 24 Mar 2021 10:11:06 -0400 Received: from localhost.localdomain (p4fefce19.dip0.t-ipconnect.de [79.239.206.25]) by mail.holtmann.org (Postfix) with ESMTPSA id BACEBCED02 for ; Wed, 24 Mar 2021 15:18:43 +0100 (CET) From: Marcel Holtmann To: linux-bluetooth@vger.kernel.org Subject: [PATCH v2 4/5] Bluetooth: Fix wrong opcode error for read advertising features Date: Wed, 24 Mar 2021 15:10:58 +0100 Message-Id: <20210324141059.88009-4-marcel@holtmann.org> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-bluetooth@vger.kernel.org The read advertising features error handling returns false the opcode for the set advertising command. Signed-off-by: Marcel Holtmann --- net/bluetooth/mgmt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/bluetooth/mgmt.c b/net/bluetooth/mgmt.c index 105d0743735d..2426a0d38c80 100644 --- a/net/bluetooth/mgmt.c +++ b/net/bluetooth/mgmt.c @@ -7478,7 +7478,7 @@ static int read_adv_features(struct sock *sk, struct hci_dev *hdev, * advertising. */ if (hci_dev_test_flag(hdev, HCI_ENABLE_LL_PRIVACY)) - return mgmt_cmd_status(sk, hdev->id, MGMT_OP_SET_ADVERTISING, + return mgmt_cmd_status(sk, hdev->id, MGMT_OP_READ_ADV_FEATURES, MGMT_STATUS_NOT_SUPPORTED); hci_dev_lock(hdev); -- 2.30.2