Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp37839pxf; Wed, 24 Mar 2021 20:12:35 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzdTyzwYrt9/9fkrBHsvk5gqygFlya5cGH4TB1m3gVnazYOUFAZW0p5tOwtxfquCEuj5SGk X-Received: by 2002:a17:906:a0d4:: with SMTP id bh20mr7024913ejb.348.1616641955615; Wed, 24 Mar 2021 20:12:35 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1616641955; cv=none; d=google.com; s=arc-20160816; b=XX9R9JNPiQT8Jlxnt7Zhpx1b3Aids9kTCvJU58jXB+KCj+zJsKIBxRYOkQRUD2rOxQ gGdGcWNAC5VrKiWfi//9zaE5HTyqBsFEofmQxBYYz0G96gOvriFf9J92ZpMSw899gcrZ zj4Br0vS3lKVC8Pw3iGWYy5S4ExkNrJRGqrGGCNaCxfXBtD39TmvqZKkqs8dsoUVi4T1 eWZiL+kwypJwdm3pi8MJwsM8Wz3Cjqkoa5IWBzq3RmXKFMNEDntTguWN0NWGkCp5/p2I uIehPAvJWIaGbcrVMwpwq05k/w+BWy3RQA/fKclbAjOJ4gvGam3uvxd55dK5PCBWkbVg XIYA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:to:from; bh=+YXVFX+M8xt451b7GyWHDRcpS/FvXXzLPiO6JjXCXV0=; b=PNpYLIPkcphDzBWsdFC88V9hz4OYeJNiv6WvzxZB6bHn4k965hVi+PzvY4fXdleEUh nX0BLXHkis1G1+8f3jigfazhCrcSA8Jd72ix9OA4g2JqFE/bvL0Z+oiOlAlJF9cEOTNA e162kUuz7cmDYStPQG6oNuw1qxbHGczAMJJ43LyWXinpkbCpzsqZha87R0NXDTQl/Ia/ bSIEFB0rIJMP48oelHpQeJpBYQCl/x2qrGKQ5W9pSwwshxCq4T5yaZkSBBHgOHf85i1B TyHmLS3e4PbNk23XXnvdbygAcEO4rJiwCOsvSBM6pRo3up96fv0Trd12MpyuPad9JPrB kSdg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-bluetooth-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id z22si2902154edc.427.2021.03.24.20.11.30; Wed, 24 Mar 2021 20:12:35 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-bluetooth-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236082AbhCXOLT (ORCPT + 99 others); Wed, 24 Mar 2021 10:11:19 -0400 Received: from coyote.holtmann.net ([212.227.132.17]:38321 "EHLO mail.holtmann.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236071AbhCXOLF (ORCPT ); Wed, 24 Mar 2021 10:11:05 -0400 Received: from localhost.localdomain (p4fefce19.dip0.t-ipconnect.de [79.239.206.25]) by mail.holtmann.org (Postfix) with ESMTPSA id 97AB1CED01 for ; Wed, 24 Mar 2021 15:18:43 +0100 (CET) From: Marcel Holtmann To: linux-bluetooth@vger.kernel.org Subject: [PATCH v2 3/5] Bluetooth: Fix mgmt status for LL Privacy experimental feature Date: Wed, 24 Mar 2021 15:10:57 +0100 Message-Id: <20210324141059.88009-3-marcel@holtmann.org> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-bluetooth@vger.kernel.org The return error when trying to change the setting when a controller is powered up, shall be MGMT_STATUS_REJECTED. However instead now the error MGMT_STATUS_NOT_POWERED is used which is exactly the opposite. Signed-off-by: Marcel Holtmann --- net/bluetooth/mgmt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/bluetooth/mgmt.c b/net/bluetooth/mgmt.c index 6b5bdf1f39ca..105d0743735d 100644 --- a/net/bluetooth/mgmt.c +++ b/net/bluetooth/mgmt.c @@ -3984,7 +3984,7 @@ static int set_exp_feature(struct sock *sk, struct hci_dev *hdev, if (hdev_is_powered(hdev)) return mgmt_cmd_status(sk, hdev->id, MGMT_OP_SET_EXP_FEATURE, - MGMT_STATUS_NOT_POWERED); + MGMT_STATUS_REJECTED); /* Parameters are limited to a single octet */ if (data_len != MGMT_SET_EXP_FEATURE_SIZE + 1) -- 2.30.2