Received-SPF: pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Content-Type: text/plain;
        charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.60.0.2.21\))
Subject: Re: [RFC PATCH v2] doc/mgmt-api - Return connection direction in
 Device Connected Event
From:   Marcel Holtmann <marcel@holtmann.org>
In-Reply-To: <20210324115840.RFC.v2.1.I530e1c3e621abd34c342d657df119e12e576d8a7@changeid>
Date:   Fri, 26 Mar 2021 08:41:11 +0100
Cc:     linux-bluetooth <linux-bluetooth@vger.kernel.org>,
        CrosBT Upstreaming <chromeos-bluetooth-upstreaming@chromium.org>,
        Miao-chen Chou <mcchou@chromium.org>,
        Alain Michaud <alainm@chromium.org>
Content-Transfer-Encoding: 7bit
Message-Id: <6BF2252B-E7BE-42BF-9C71-D7A08AFC5C10@holtmann.org>
References: <20210324115840.RFC.v2.1.I530e1c3e621abd34c342d657df119e12e576d8a7@changeid>
To:     Yu Liu <yudiliu@google.com>
Precedence: bulk

Hi Yu,

> When an MGMT_EV_DEVICE_CONNECTED event is reported back to the user
> space we will set the flags to tell if the established connection is
> outbound or not. This is useful for the user space to log better metrics
> and error messages.
> 
> Reviewed-by: Miao-chen Chou <mcchou@chromium.org>
> Reviewed-by: Alain Michaud <alainm@chromium.org>
> Signed-off-by: Yu Liu <yudiliu@google.com>
> ---
> 
> Changes in v2:
> - Use next free bit
> 
> Changes in v1:
> - Initial change
> 
> doc/mgmt-api.txt | 1 +
> 1 file changed, 1 insertion(+)
> 
> diff --git a/doc/mgmt-api.txt b/doc/mgmt-api.txt
> index cab1fffc5..98552e761 100644
> --- a/doc/mgmt-api.txt
> +++ b/doc/mgmt-api.txt
> @@ -4088,6 +4088,7 @@ Device Connected Event
> 		0	Reserved (not in use)
> 		1	Legacy Pairing
> 		2	Reserved (not in use)
> +		3	Initiated Connection

please also mark it reserved in Device Found event.

Regards

Marcel