Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp3757115pxf; Mon, 29 Mar 2021 10:31:17 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzZwelVTdq93SX+T4pDLh149DGl+j16GkIcOdd5W1V26+51DZRa7b9RY7dZjW3Gc/dCpQ5K X-Received: by 2002:a17:906:948d:: with SMTP id t13mr28807721ejx.402.1617039077250; Mon, 29 Mar 2021 10:31:17 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1617039077; cv=none; d=google.com; s=arc-20160816; b=h1eAd9RDVysuKVfpvj9/KZGj3JzfivulGmxGhlV8aB8IcYXhc9HjBdlNZSqc1J4g3y sngP69Bu9zkk2hO9uML6zRZFfmw4qCyLYFEn7xX7if4lV+9qY4I53wfT2OZAeFhej7yj cpzQUCS+ILpJMn+EAvdO+NVLHTSFcGXPy5F+cPvy6xrQ8wtO0f41yJGzHVhOAPbrC8j1 PGglYD20vFn5Ng+b9wSah51snELl/MXe0/8MpIo3gGtUDf13QWsJ0sZFjFJfDvYX3d4B Xo66QQz0DaIxm/9NOtXLWzRjVSNaeXfeoLoA/H8VXrFTR1wDT+i/h7cyG0/wraTeLAlS icAA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:to:from:dkim-signature; bh=Xq8ca9NLJfG3o1JyMrCOMOp3uD86KQjuHEhSu8hpy1U=; b=0T/ZcmPZmAfiVGtgXQwAQcdW0xEhzsBjV/zdN+c2RPHya+S+aWkmUnNezcx3qJWm4z oKytOnRVoHAlNVQpAnl4JNEVPEQKnRcs1TKmC8uW6X+17dNi5Ag4KVfbu3Enxn4FEmX8 qe/j+yvlsJ9u24GMZZuQcr0M/LZsLfgEe6lVF7LrvCTKGWy7UhvOwhaQjjbeJ308yDcy L0U0hsniL3troybs1a/PEXEJXcc/ACd1RJkzDiVS3Gkg7TeyNdXWh1lbBbRvAq1F9aWs GL1B1kWMT7OYyamgUrsnZN7oJf/7MJD3ionv1v07kgsae3iyEWnv9MgUGOa4eONxfJKU khkw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=eeIsIc4x; spf=pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-bluetooth-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id jx25si12440656ejc.382.2021.03.29.10.30.37; Mon, 29 Mar 2021 10:31:17 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=eeIsIc4x; spf=pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-bluetooth-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229822AbhC2R10 (ORCPT + 99 others); Mon, 29 Mar 2021 13:27:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55778 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230437AbhC2R1G (ORCPT ); Mon, 29 Mar 2021 13:27:06 -0400 Received: from mail-pg1-x534.google.com (mail-pg1-x534.google.com [IPv6:2607:f8b0:4864:20::534]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 079D0C061574 for ; Mon, 29 Mar 2021 10:27:06 -0700 (PDT) Received: by mail-pg1-x534.google.com with SMTP id v10so9821713pgs.12 for ; Mon, 29 Mar 2021 10:27:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:date:message-id:mime-version :content-transfer-encoding; bh=Xq8ca9NLJfG3o1JyMrCOMOp3uD86KQjuHEhSu8hpy1U=; b=eeIsIc4x9xpAUtdgotMV1XEOCpIe80M6W0TLd7min6B40qUWzFBbp5k0wz27YAU0Qc mfb8BhK0J8fpXvd4VXbNF8l74SEXRQNY2ZWZSCsy7KCP4q1Esb56WoXjW9nE249uZA+U VxkBmSo5KH33WlUJj0aQgFH6wt+mI6f79eTb4wYXY55CynUcF1VllD2nmPaEtxOXhQIX OtI3TyQPIu9L/hVyKIhYmnCGUqzeL3k6bIE0//hHMK1xg9aaRQVTFgB2Hzzjqe0Z0tLS cM9noZA5pr5bHc7zUmEymAEHzbu0iWpcEx+zu9OHPAdeP9jxPhTRVPJnUCnuR8HbFdqv zJwA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:mime-version :content-transfer-encoding; bh=Xq8ca9NLJfG3o1JyMrCOMOp3uD86KQjuHEhSu8hpy1U=; b=RyMQCISrDIjmwKtgeY/MxFcXqOMbDYKtCg3dOzF1sNsjec9HvzyJ+AigatBOnh/pdv /oGbKms1j2sYsEvdEOTeieahMoZabIkPO5F4X+vAMxc0nmDMfq7wIh6/58IZxXfVmAZx /hPBPeckY5jVCd882ddzQ/qr74GIPsjyC/sXj9ZYMBsq3ig7ybaInRWsY9TAW7l2K+QP kVgmnTtPeiqrV7FJyjSp6iyd05+h9aW+PiQthFygA2SWJayKXnVG2XHaUlhivYw1YNFq 6cN7WUPAnwYxZeEUnvXIob1mFlogRRzdXEI8fN+U7NvhjKGjf6qNo+0M0GbQ2ur+BiHE b1Lw== X-Gm-Message-State: AOAM532mFlvX4byE7cMIEAuu5HONC6ffH1cjN8dmecz2i/ZqxZWzYdxp kFqjByMSsxt6pLUlWRMcqLRXq8Rdvw8sew== X-Received: by 2002:a63:2c8a:: with SMTP id s132mr2811150pgs.165.1617038825324; Mon, 29 Mar 2021 10:27:05 -0700 (PDT) Received: from lvondent-mobl4.intel.com (c-71-56-157-77.hsd1.or.comcast.net. [71.56.157.77]) by smtp.gmail.com with ESMTPSA id y194sm17379642pfb.21.2021.03.29.10.27.04 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 29 Mar 2021 10:27:04 -0700 (PDT) From: Luiz Augusto von Dentz To: linux-bluetooth@vger.kernel.org Subject: [PATCH] Bluetooth: SMP: Fix variable dereferenced before check 'conn' Date: Mon, 29 Mar 2021 10:27:04 -0700 Message-Id: <20210329172704.117731-1-luiz.dentz@gmail.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-bluetooth@vger.kernel.org From: Luiz Augusto von Dentz This fixes kbuild findings: smatch warnings: net/bluetooth/smp.c:1633 smp_user_confirm_reply() warn: variable dereferenced before check 'conn' (see line 1631) Signed-off-by: Luiz Augusto von Dentz Reported-by: kernel test robot Reported-by: Dan Carpenter --- net/bluetooth/smp.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/net/bluetooth/smp.c b/net/bluetooth/smp.c index 2def90668173..5c17acfb1645 100644 --- a/net/bluetooth/smp.c +++ b/net/bluetooth/smp.c @@ -1628,11 +1628,11 @@ int smp_user_confirm_reply(struct hci_conn *hcon, u16 mgmt_op, __le32 passkey) u32 value; int err; - bt_dev_dbg(conn->hcon->hdev, ""); - if (!conn) return -ENOTCONN; + bt_dev_dbg(conn->hcon->hdev, ""); + chan = conn->smp; if (!chan) return -ENOTCONN; -- 2.30.2