Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp332897pxf; Wed, 31 Mar 2021 04:40:33 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzJQIvb+pbOuxzEiKyJKcaE4ciUV4GQBUcEWyBpZ3UGhjvMrsiUvl0wZAesJuIe+zJzwYch X-Received: by 2002:a17:906:c102:: with SMTP id do2mr3008856ejc.305.1617190832740; Wed, 31 Mar 2021 04:40:32 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1617190832; cv=none; d=google.com; s=arc-20160816; b=w9VSLb8UV8slh1yHid286JRrz64EW5pL3UtHgkiItPbKH8suGZD3Nu7Ytjkj8Y7NCk NfWPkNeXGFxl9nUohI6LmEXWyx4KJHNVjp8gBfe+Si/UrQFoJex3hSd+iZTWbBxfPfpl zei0hjQJ5let2wVVNaZQKkjTW9yQ/mlaIyKrztvL/SJBIkchiI0XQZr72Wrng+7uWVZd Bb7DRdrIbYR0eECNHZrb/+PWJi9/Is7r3yNy9/J5go17peqvtj6eZZuiMzippxU+0Fmw iE9RvY+r6RzWVBH9fjj3aPLLN852+TtJ0taiHjaMOSNqZP/ej129VbF7pZOVbZKtYOdY +mwA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-language:content-transfer-encoding :mime-version:user-agent:date:message-id:subject:from:cc:to :dkim-signature; bh=AOcZoBRnKJ1Sm+gu9zdQ817E3kMzHA9eGyEcNRDE+d4=; b=HK3tcw5X+eSNAfw96xXa/Adn2tGVOP4KQQAaPY6RzKNpy2OM7scPmVKIPh/qChXBto j2IElMlK/s34UoFZ39RUKYNEzoubd4yuLt0QJTtp7m50R3DXu5eCayL4hXU12CVagsUQ iwvJYP/oFWfVSQMJlk9tftbGhlIIwGuIRrgmvEAeYZcfu1bRcshTQeri3B6rlerjRTDB Yw1rBT4RWEpFWd3yit+HcL/VV5w4WLJ1E0dTDU1R0ghEkG4Nhaail5Zesrc18Q84SKle tyJa6lZiwcRqq8D8eajs3edQ5rrngnsVR6EsGhcUJQQBGTNX9KzQyhO+3v4GiA+Z/Rr7 bdVA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=ufMLi3gs; spf=pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-bluetooth-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id rl4si1244999ejb.229.2021.03.31.04.39.54; Wed, 31 Mar 2021 04:40:32 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=ufMLi3gs; spf=pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-bluetooth-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235085AbhCaLhB (ORCPT + 99 others); Wed, 31 Mar 2021 07:37:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36822 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234987AbhCaLg5 (ORCPT ); Wed, 31 Mar 2021 07:36:57 -0400 Received: from mail-wm1-x32a.google.com (mail-wm1-x32a.google.com [IPv6:2a00:1450:4864:20::32a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9E33EC061574 for ; Wed, 31 Mar 2021 04:36:56 -0700 (PDT) Received: by mail-wm1-x32a.google.com with SMTP id b2-20020a7bc2420000b029010be1081172so986983wmj.1 for ; Wed, 31 Mar 2021 04:36:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=to:cc:from:subject:message-id:date:user-agent:mime-version :content-transfer-encoding:content-language; bh=AOcZoBRnKJ1Sm+gu9zdQ817E3kMzHA9eGyEcNRDE+d4=; b=ufMLi3gs/P2bg+onMCZid6xIH0JgjJ/aPK4949NaGrkqNZHCTHg9i1vNBNAEKn0xUS NHSbjfT+ihpikeDaRSth90HWkLyxx/1kp5XyabWDclgvkJd9LI9kg7gPrQfbnVzyaBLX vN4SGq2qP5lDVJqetLw6cI9+iYKmt/wjNE4PgIct2mrUFyiKaAXk2kdXXX4dQeExTS/e x7z43LpbZB39EWaRUTzJ8EJVmekQ7OGO1HSS5Iu88JCTtLH1CLP7AXwctj3Xc6pqdLLN 2FeOwuLm9gyF4b+OsAYiZiSsZNveKGI2yGPjTkVGU1uZt/IqO/DC2y7WoipquAKsKWQ6 M0zg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:to:cc:from:subject:message-id:date:user-agent :mime-version:content-transfer-encoding:content-language; bh=AOcZoBRnKJ1Sm+gu9zdQ817E3kMzHA9eGyEcNRDE+d4=; b=t50y9fWrTb7yyiD/d5Y9PwZV0yeDzmG/V2bGrRibVXzLEZ+3Im7wMvZ4AhcIghqum+ HzulsajwKin7ijQ/GgiEJWJNlPQxvCzrTNMPf/wvh+cECjpcXFBNU3feJsGr1oyGm2+W rHmn8S9BHhO/t4tEbUrrq4yxUVmZS6pcnttbDCy45/J/jrahzX/PnUAFDXuxqNNYo578 BThT6LkV9wf01/wVxtssTi2MQz8BL+2hw2fbUfXo8deJReyf1kvd8Xhk8M0yhFjxdUPg tB1IziEQXNtJ3l2H/zTjc5Bnwxt/q7DhO0IxbW1CfwLLm2iDNlctajpZ1UNF8pxIbxXV hGkg== X-Gm-Message-State: AOAM532F5Xjrc7yrv5ESopXlLs/vwKhOO6LywyMz/UBI2cWptdthAHuW 2f88d8q2o3egEVKTIxWV/A== X-Received: by 2002:a1c:4b0a:: with SMTP id y10mr2701656wma.141.1617190615417; Wed, 31 Mar 2021 04:36:55 -0700 (PDT) Received: from [192.168.1.125] (ip-37-201-4-244.hsi13.unitymediagroup.de. [37.201.4.244]) by smtp.gmail.com with ESMTPSA id b17sm3850725wrt.17.2021.03.31.04.36.54 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 31 Mar 2021 04:36:55 -0700 (PDT) To: linux-bluetooth@vger.kernel.org Cc: feryllt@gmail.com From: Feryllt Pryderi Subject: [PATCH BlueZ] audio/transport: Emit Volume changed if endpoint is source Message-ID: <80f40fbd-c903-6f10-1d9f-e75f0f214db5@gmail.com> Date: Wed, 31 Mar 2021 13:38:12 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.9.0 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Content-Language: en-US Precedence: bulk List-ID: X-Mailing-List: linux-bluetooth@vger.kernel.org Change set_volume to send a Volume PropertyChanged signal also if transport->sink_watch is set (and not only if source_watch is set). This fixes volume changes signals not being sent for devices like speakers and headphone adapters with volume control (like Bose Soundlink Revolve or Fiio BTR5). ---  profiles/audio/transport.c | 1 +  1 file changed, 1 insertion(+) diff --git a/profiles/audio/transport.c b/profiles/audio/transport.c index 8248014ae..26aa237a3 100644 --- a/profiles/audio/transport.c +++ b/profiles/audio/transport.c @@ -662,6 +662,7 @@ static void set_volume(const GDBusPropertyTable *property,      a2dp->volume = volume;        notify = transport->source_watch ? true : false; +    notify = notify || (transport->sink_watch ? true : false);      if (notify)          g_dbus_emit_property_changed(btd_get_dbus_connection(),                          transport->path, -- 2.31.0