Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp1137967pxf; Fri, 2 Apr 2021 02:11:08 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzldS8llAvlUs7Pt03rsmmgRz8mk94GgNYS4gncuxNOGKj8Uuk+3yp1r/U1rTqtNv6gQ5r3 X-Received: by 2002:a17:906:d9c9:: with SMTP id qk9mr12874187ejb.504.1617354668026; Fri, 02 Apr 2021 02:11:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1617354668; cv=none; d=google.com; s=arc-20160816; b=MSYPp9Ppj9SHy8t5BWbiqKkvWbRZbBaYIVcEDqKDtGXl+PHt+ji7PKlL12N+EFOvtj F83/VJmjKNJYH+3ZVwWjfFL0E4kTBUhl1oWsoPDpjQjcNe8kFAz74jkoRpZ8kkN8W0/6 p9z2VBtE42lOBFvj4vX+vLwcisYnuHKWF4afC9yOpLQ/Kac2ka00wrvbSH6Ai5s+JOSh Po0afwGq7qQtrhgwSIpZAy06aJs8wwI0PiWQi4eZZ93QEO2OCDZD5v+7vOkBBug5RwR8 XdYOYNHIVWg/dtKwP+t1/+8EHPP2pc7GT0UDfCQA4SDcLpbDVCooz02xDulg4A2Eq2ci CVWA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:to:references:message-id :content-transfer-encoding:cc:date:in-reply-to:from:subject :mime-version; bh=Kjqi8M0KcFPVbtg4Mq2mAuGkqsmTcZNRLDlkhZFwvrw=; b=TWoB1vvGTpwMMU8JVHlNLGx+X/lNmoMtZkvNJCGU7gUZJ3l7aorPh2VMaZ6rhR9S4a PABMVHM09wvgJ5Ce0JDmOMaBu+fKM814DZmjnVcvuGhgyMAhRa3k65LtzNz/X8HHRawv myVCSFB0DZ8Hm2Ck11HnV4/gjaQn9n/ztJ8NfTKak7eYPhohcObECtSzpG3+goMua1QW Od+Qn67qoqOt8mDP6TN0iQAwUAAbK8SQL2hrGoXJD2MlKNE8DqvAULTyt7S5dTwFC2Ww kefcE2UqpNFY5rb8xvrM4c7zqU8TIqIdJVMQiA5usRYRMlzvFAzOW1CTKF2SL4jv0CFo 6cxg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-bluetooth-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id a21si5923405ejr.620.2021.04.02.02.10.44; Fri, 02 Apr 2021 02:11:08 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-bluetooth-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234533AbhDBJJs (ORCPT + 99 others); Fri, 2 Apr 2021 05:09:48 -0400 Received: from coyote.holtmann.net ([212.227.132.17]:50269 "EHLO mail.holtmann.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229553AbhDBJJr (ORCPT ); Fri, 2 Apr 2021 05:09:47 -0400 Received: from marcel-macbook.holtmann.net (p5b3d2269.dip0.t-ipconnect.de [91.61.34.105]) by mail.holtmann.org (Postfix) with ESMTPSA id 31879CED24; Fri, 2 Apr 2021 11:17:25 +0200 (CEST) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.60.0.2.21\)) Subject: Re: [PATCH] Bluetooth: Check inquiry status before sending one From: Marcel Holtmann In-Reply-To: <20210401111036.1.I26d172ded4e4ac8ad334516a8d196539777fba2a@changeid> Date: Fri, 2 Apr 2021 11:09:43 +0200 Cc: linux-bluetooth , CrosBT Upstreaming , Archie Pusaka , Sonny Sasaka , "David S. Miller" , Jakub Kicinski , Johan Hedberg , Luiz Augusto von Dentz , LKML , netdev@vger.kernel.org Content-Transfer-Encoding: 7bit Message-Id: <314A4670-B821-4FD5-B7A3-5B04B489D39D@holtmann.org> References: <20210401111036.1.I26d172ded4e4ac8ad334516a8d196539777fba2a@changeid> To: Archie Pusaka X-Mailer: Apple Mail (2.3654.60.0.2.21) Precedence: bulk List-ID: X-Mailing-List: linux-bluetooth@vger.kernel.org Hi Archie, > There is a possibility where HCI_INQUIRY flag is set but we still > send HCI_OP_INQUIRY anyway. > > Such a case can be reproduced by connecting to an LE device while > active scanning. When the device is discovered, we initiate a > connection, stop LE Scan, and send Discovery MGMT with status > disabled, but we don't cancel the inquiry. > > Signed-off-by: Archie Pusaka > Reviewed-by: Sonny Sasaka > --- > > net/bluetooth/hci_request.c | 3 +++ > 1 file changed, 3 insertions(+) patch has been applied to bluetooth-next tree. Regards Marcel