Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp1138964pxf; Fri, 2 Apr 2021 02:13:18 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzJvuVWGNAS1xloAJtpI9OUvwu03+YSVYURzXfgfHaQjAyU0RRLif8465IJZpjNt2MDBdc8 X-Received: by 2002:a17:906:4e99:: with SMTP id v25mr13108327eju.532.1617354797979; Fri, 02 Apr 2021 02:13:17 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1617354797; cv=none; d=google.com; s=arc-20160816; b=BKl4Z6o5qRxqbnQDsNpsS0bagchJ/DkOXFm+75LbSC8OJqXsb5StYL1ZFly+Ka1lY5 JVwCoPGXJfUj9FQVUcfdIYzS73O5w+mn/1rXaj3vttPZC9cvaBTUQvtDQN9k0p+pxplX mQ/uGaUblLpJpyrUz5NRUaBLoDK+FlFvVEWpShCEAiL2zIrLoI0bKyPhdZOMboxumsQl UQzUn6hKnLo25N2NsDqareha7GSqfNI0RzGrhpJM/1v43mwQ7U/NBQH/jeGRw4Z7mgLY g88U86nq/U3dLWrnCMJ4Q9kF6rVJGP1kjR5gh+Z6r19/Bo/Zi5k1N4HBSgCcCVgacgRJ uEfg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:to:references:message-id :content-transfer-encoding:cc:date:in-reply-to:from:subject :mime-version; bh=8wOBzAfbE/xP++kZEazlSRs76JVXxFxSNfQCkNkP/Mo=; b=dWXpv0+bAwNfhstK2KwnGGi4rPR/JnFYHoNLRzr8W68cZiOzJCBxUnG2VNkOOM+eWX zEDDfA5NogUrMTH2DPfxYpzCg8UCfZFPYwq0uh+Pjm9aTzjgcAFL26ahFT3ZELvK3qDq c9xHH+u62x/6bnY0GOG+jWFKYWE1sQsKdzxta25CWsQGFiYpSqvMrJxJK9KgojWgTs33 Kp2iqmcYLLjNV1UHz1v2UwuJpYGZamRjd7c4ZURmQRAKqKJKFns9Nigw6TZHcqECr91z LosKPOkF26xbIfbA9q+IU0Itt3kD7tVg/lf5g1AZRlD3B+kETXLKt2fvhUYMm097k9Pp NmTQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-bluetooth-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id h3si274217ejf.479.2021.04.02.02.12.52; Fri, 02 Apr 2021 02:13:17 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-bluetooth-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233718AbhDBJMA (ORCPT + 99 others); Fri, 2 Apr 2021 05:12:00 -0400 Received: from coyote.holtmann.net ([212.227.132.17]:42903 "EHLO mail.holtmann.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234275AbhDBJL7 (ORCPT ); Fri, 2 Apr 2021 05:11:59 -0400 Received: from marcel-macbook.holtmann.net (p5b3d2269.dip0.t-ipconnect.de [91.61.34.105]) by mail.holtmann.org (Postfix) with ESMTPSA id 7E105CED23; Fri, 2 Apr 2021 11:19:39 +0200 (CEST) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.60.0.2.21\)) Subject: Re: [PATCH] Bluetooth: SMP: Fix variable dereferenced before check 'conn' From: Marcel Holtmann In-Reply-To: <20210329172704.117731-1-luiz.dentz@gmail.com> Date: Fri, 2 Apr 2021 11:11:57 +0200 Cc: linux-bluetooth@vger.kernel.org Content-Transfer-Encoding: 7bit Message-Id: References: <20210329172704.117731-1-luiz.dentz@gmail.com> To: Luiz Augusto von Dentz X-Mailer: Apple Mail (2.3654.60.0.2.21) Precedence: bulk List-ID: X-Mailing-List: linux-bluetooth@vger.kernel.org Hi Luiz, > This fixes kbuild findings: > > smatch warnings: > net/bluetooth/smp.c:1633 smp_user_confirm_reply() warn: variable > dereferenced before check 'conn' (see line 1631) > > Signed-off-by: Luiz Augusto von Dentz > Reported-by: kernel test robot > Reported-by: Dan Carpenter > --- > net/bluetooth/smp.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) patch has been applied to bluetooth-next tree. Regards Marcel