Received-SPF: pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Szymon Janc <szymon.janc@codecoup.pl>
To:     linux-bluetooth@vger.kernel.org,
        Sathish Narasimman <sathish.narasimman@intel.com>
Cc:     chethan.tumkur.narayan@intel.com, ravishankar.srivatsa@intel.com,
        Sathish Narasimman <sathish.narasimman@intel.com>
Subject: Re: [PATCH 2/2] Bluetooth: LL privacy allow RPA
Date:   Tue, 06 Apr 2021 16:17:13 +0200
Message-ID: <5698706.lOV4Wx5bFT@ix>
Organization: CODECOUP
In-Reply-To: <20210405143041.16168-1-sathish.narasimman@intel.com>
References: <20210405143041.16168-1-sathish.narasimman@intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Precedence: bulk

Hi,

On Monday, 5 April 2021 16:30:41 CEST Sathish Narasimman wrote:
> allow RPA to add bd address to whitelist
> 
> Signed-off-by: Sathish Narasimman <sathish.narasimman@intel.com>
> ---
>  net/bluetooth/hci_request.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/net/bluetooth/hci_request.c b/net/bluetooth/hci_request.c
> index 0d78122342d5..560b74d421a8 100644
> --- a/net/bluetooth/hci_request.c
> +++ b/net/bluetooth/hci_request.c
> @@ -847,6 +847,10 @@ static u8 update_white_list(struct hci_request *req)
>  	 */
>  	bool allow_rpa = hdev->suspended;
> 
> +	if (use_ll_privacy(hdev) &&
> +	    hci_dev_test_flag(hdev, HCI_ENABLE_LL_PRIVACY))
> +		allow_rpa = true;
> +
>  	/* Go through the current white list programmed into the
>  	 * controller one by one and check if that address is still
>  	 * in the list of pending connections or list of devices to

I'm bit confused by this patch. Why add RPA to whitelist if LL privacy is in 
use?

-- 
pozdrawiam
Szymon Janc