Received-SPF: pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Content-Type: text/plain;
        charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.60.0.2.21\))
Subject: Re: [PATCH 5.12 regression fix resend 1/1] Bluetooth: btusb: Revert
 Fix the autosuspend enable and disable
From:   Marcel Holtmann <marcel@holtmann.org>
In-Reply-To: <20210405203533.17091-2-hdegoede@redhat.com>
Date:   Fri, 9 Apr 2021 15:45:12 +0200
Cc:     Johan Hedberg <johan.hedberg@gmail.com>,
        Luiz Augusto von Dentz <luiz.dentz@gmail.com>,
        Hui Wang <hui.wang@canonical.com>,
        linux-bluetooth@vger.kernel.org
Content-Transfer-Encoding: 8BIT
Message-Id: <C8344B39-AED4-4F18-99F8-C822EA500FEC@holtmann.org>
References: <20210405203533.17091-1-hdegoede@redhat.com>
 <20210405203533.17091-2-hdegoede@redhat.com>
To:     Hans de Goede <hdegoede@redhat.com>
Precedence: bulk

Hi Hans,

> drivers/usb/core/hub.c: usb_new_device() contains the following:
> 
>        /* By default, forbid autosuspend for all devices.  It will be
>         * allowed for hubs during binding.
>         */
>        usb_disable_autosuspend(udev);
> 
> So for anything which is not a hub, such as btusb devices, autosuspend is
> disabled by default and we must call usb_enable_autosuspend(udev) to
> enable it.
> 
> This means that the "Fix the autosuspend enable and disable" commit,
> which drops the usb_enable_autosuspend() call when the enable_autosuspend
> module option is true, is completely wrong, revert it.
> 
> This reverts commit 7bd9fb058d77213130e4b3e594115c028b708e7e.
> 
> Cc: Hui Wang <hui.wang@canonical.com>
> Fixes: 7bd9fb058d77 ("Bluetooth: btusb: Fix the autosuspend enable and disable")
> Acked-by: Hui Wang <hui.wang@canonical.com>
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
> ---
> drivers/bluetooth/btusb.c | 7 ++-----
> 1 file changed, 2 insertions(+), 5 deletions(-)

since we are already at -rc6, I think it makes more sense that you send it directly to Linus for inclusion.

Acked-by: Marcel Holtmann <marcel@holtmann.org>

Regards

Marcel