Received: by 2002:a05:6a10:a852:0:0:0:0 with SMTP id d18csp216580pxy; Fri, 7 May 2021 01:24:11 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwrs3KTFyJQj1iW1ygjsSLSxcg31l7lM27KhsOgzo6r3vSYhueTyhjU4fyush2O9OfKeAy4 X-Received: by 2002:a50:ec86:: with SMTP id e6mr9883326edr.39.1620375850794; Fri, 07 May 2021 01:24:10 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1620375850; cv=none; d=google.com; s=arc-20160816; b=A6+NYd4Rbo58jh7aK9LBu2txFg6n0YbpsDI9hf/AUdlNxLOjwvnMnOU65xB40FsIbw a603vRV3t6V7/v/K0i16JgfgWt1pX0U+jL4mhQxUfhtXDTwthhO1PqKeus6F4DNJQ784 Z++/6LLZ3UOFZ/ONEbY/t58YYhcypcBJsI/59nmSQAoMj41WMDXkL/Xln7lgqV7xusNp CDZrkYx9zUybt30OHXbVW4j1tclRv3GSCu6IWAfSf+Q6qtNXngtSTVOPVOrnExNAYSqo pLOg+z+X/LKRXmHAts9KO6LUtw3sz1EcQKAGIRVMhwy9jeI+dven2V1iS8tJTz9TncZb nvNg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :ironport-sdr:ironport-sdr; bh=0N5PBSRFf764rcdCKKpZBROZV0iHyp+tORDjlfY1srY=; b=XMlyIhPxFpiT2Xd3afN+3CocrcwLNGUAaIuZm9fsvmzKoSnUiTPOKqBI53/a+D6FHV wpkclEmeuSZiY0KkLj7rJhelrc+rwX4dxHJ+dCdmLnYjdSk59jgztQImkC6cXQWS3Loq nF0TxT24b2njkUYaY/bYE0esQypH5wcwPdQAuXU6cyVc/0d573r3k73S3W6J+7vI08pM UpRLmp20/ojll1ZG23ykACGiUnBeCopzjPzJ0N3taJOC3EtbrR7C8YtDNqOXbJkwtXzN dvRy8yh/CIj4/MohE8suY0Ubs8/aDdQrk8X/Tsspj5st/1B2IKNRCXeCmV1vHsQBIpRY pR6A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-bluetooth-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id v20si4698123edc.437.2021.05.07.01.23.47; Fri, 07 May 2021 01:24:10 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-bluetooth-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234370AbhEGF5o (ORCPT + 99 others); Fri, 7 May 2021 01:57:44 -0400 Received: from mga02.intel.com ([134.134.136.20]:15465 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234286AbhEGF5l (ORCPT ); Fri, 7 May 2021 01:57:41 -0400 IronPort-SDR: voaRLQv2hJ9d0asdnUFyuMu8Z25GcyR+PN/P0y5RAZ6I7CryH8lQLKwDoLXbmOw8TjlREE8cL+ hNGrd9ImChpw== X-IronPort-AV: E=McAfee;i="6200,9189,9976"; a="185786437" X-IronPort-AV: E=Sophos;i="5.82,279,1613462400"; d="scan'208";a="185786437" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 May 2021 22:56:42 -0700 IronPort-SDR: LK8DV3mIbEaoTTMYdlGXjSekY5UOYhqH7uJTZKMtYEqBixQwxpcM0CB1BtkYeNcuyhyz/3VF2D 5VeRhDsywmfg== X-IronPort-AV: E=Sophos;i="5.82,279,1613462400"; d="scan'208";a="407314557" Received: from jinhuach-mobl1.ccr.corp.intel.com (HELO istotlan-desk.intel.com) ([10.254.7.101]) by orsmga002-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 May 2021 22:56:41 -0700 From: Inga Stotland To: linux-bluetooth@vger.kernel.org Cc: luiz.dentz@gmail.com, Inga Stotland Subject: [RFC BlueZ v2 06/11] tools/smp-tester: Convert to use ELL library Date: Thu, 6 May 2021 22:56:24 -0700 Message-Id: <20210507055629.338409-7-inga.stotland@intel.com> X-Mailer: git-send-email 2.26.3 In-Reply-To: <20210507055629.338409-1-inga.stotland@intel.com> References: <20210507055629.338409-1-inga.stotland@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-bluetooth@vger.kernel.org This reworks the source code to use ELL primitives and removes dependencies on GLib. --- Makefile.tools | 4 +- tools/smp-tester.c | 210 +++++++++++++++++++++------------------------ 2 files changed, 102 insertions(+), 112 deletions(-) diff --git a/Makefile.tools b/Makefile.tools index 9193beef8..77b8d5512 100644 --- a/Makefile.tools +++ b/Makefile.tools @@ -144,12 +144,12 @@ tools_bnep_tester_LDADD = lib/libbluetooth-internal.la \ src/libshared-glib.la $(GLIB_LIBS) tools_smp_tester_SOURCES = tools/smp-tester.c monitor/bt.h \ - emulator/hciemu.h emulator/hciemu.c \ + emulator/hciemu.h emulator/hciemu-ell.c \ emulator/btdev.h emulator/btdev.c \ emulator/bthost.h emulator/bthost.c \ emulator/smp.c tools_smp_tester_LDADD = lib/libbluetooth-internal.la \ - src/libshared-glib.la $(GLIB_LIBS) + src/libshared-ell.la $(ell_ldadd) tools_gap_tester_SOURCES = tools/gap-tester.c monitor/bt.h \ emulator/hciemu.h emulator/hciemu-ell.c \ diff --git a/tools/smp-tester.c b/tools/smp-tester.c index 644c451c2..f78ab6fd8 100644 --- a/tools/smp-tester.c +++ b/tools/smp-tester.c @@ -18,7 +18,7 @@ #include #include -#include +#include #include "lib/bluetooth.h" #include "lib/hci.h" @@ -30,7 +30,7 @@ #include "src/shared/crypto.h" #include "src/shared/ecc.h" -#include "src/shared/tester.h" +#include "src/shared/bttester.h" #include "src/shared/mgmt.h" #define SMP_CID 0x0006 @@ -41,7 +41,6 @@ struct test_data { uint16_t mgmt_index; struct hciemu *hciemu; enum hciemu_type hciemu_type; - unsigned int io_id; uint8_t ia[6]; uint8_t ia_type; uint8_t ra[6]; @@ -82,27 +81,29 @@ struct smp_data { bool sc; }; +static struct l_tester *tester; + static void print_debug(const char *str, void *user_data) { const char *prefix = user_data; - tester_print("%s%s", prefix, str); + bttester_print("%s%s", prefix, str); } static void read_info_callback(uint8_t status, uint16_t length, const void *param, void *user_data) { - struct test_data *data = tester_get_data(); + struct test_data *data = l_tester_get_data(tester); const struct mgmt_rp_read_info *rp = param; char addr[18]; uint16_t manufacturer; uint32_t supported_settings, current_settings; - tester_print("Read Info callback"); - tester_print(" Status: 0x%02x", status); + bttester_print("Read Info callback"); + bttester_print(" Status: 0x%02x", status); if (status || !param) { - tester_pre_setup_failed(); + l_tester_pre_setup_failed(tester); return; } @@ -111,31 +112,31 @@ static void read_info_callback(uint8_t status, uint16_t length, supported_settings = btohl(rp->supported_settings); current_settings = btohl(rp->current_settings); - tester_print(" Address: %s", addr); - tester_print(" Version: 0x%02x", rp->version); - tester_print(" Manufacturer: 0x%04x", manufacturer); - tester_print(" Supported settings: 0x%08x", supported_settings); - tester_print(" Current settings: 0x%08x", current_settings); - tester_print(" Class: 0x%02x%02x%02x", + bttester_print(" Address: %s", addr); + bttester_print(" Version: 0x%02x", rp->version); + bttester_print(" Manufacturer: 0x%04x", manufacturer); + bttester_print(" Supported settings: 0x%08x", supported_settings); + bttester_print(" Current settings: 0x%08x", current_settings); + bttester_print(" Class: 0x%02x%02x%02x", rp->dev_class[2], rp->dev_class[1], rp->dev_class[0]); - tester_print(" Name: %s", rp->name); - tester_print(" Short name: %s", rp->short_name); + bttester_print(" Name: %s", rp->name); + bttester_print(" Short name: %s", rp->short_name); if (strcmp(hciemu_get_address(data->hciemu), addr)) { - tester_pre_setup_failed(); + l_tester_pre_setup_failed(tester); return; } - tester_pre_setup_complete(); + l_tester_pre_setup_complete(tester); } static void index_added_callback(uint16_t index, uint16_t length, const void *param, void *user_data) { - struct test_data *data = tester_get_data(); + struct test_data *data = l_tester_get_data(tester); - tester_print("Index Added callback"); - tester_print(" Index: 0x%04x", index); + bttester_print("Index Added callback"); + bttester_print(" Index: 0x%04x", index); data->mgmt_index = index; @@ -146,10 +147,10 @@ static void index_added_callback(uint16_t index, uint16_t length, static void index_removed_callback(uint16_t index, uint16_t length, const void *param, void *user_data) { - struct test_data *data = tester_get_data(); + struct test_data *data = l_tester_get_data(tester); - tester_print("Index Removed callback"); - tester_print(" Index: 0x%04x", index); + bttester_print("Index Removed callback"); + bttester_print(" Index: 0x%04x", index); if (index != data->mgmt_index) return; @@ -159,19 +160,19 @@ static void index_removed_callback(uint16_t index, uint16_t length, mgmt_unref(data->mgmt); data->mgmt = NULL; - tester_post_teardown_complete(); + l_tester_post_teardown_complete(tester); } static void read_index_list_callback(uint8_t status, uint16_t length, const void *param, void *user_data) { - struct test_data *data = tester_get_data(); + struct test_data *data = l_tester_get_data(tester); - tester_print("Read Index List callback"); - tester_print(" Status: 0x%02x", status); + bttester_print("Read Index List callback"); + bttester_print(" Status: 0x%02x", status); if (status || !param) { - tester_pre_setup_failed(); + l_tester_pre_setup_failed(tester); return; } @@ -183,36 +184,36 @@ static void read_index_list_callback(uint8_t status, uint16_t length, data->hciemu = hciemu_new(data->hciemu_type); if (!data->hciemu) { - tester_warn("Failed to setup HCI emulation"); - tester_pre_setup_failed(); + bttester_warn("Failed to setup HCI emulation"); + l_tester_pre_setup_failed(tester); } - if (tester_use_debug()) + if (bttester_use_debug()) hciemu_set_debug(data->hciemu, print_debug, "hciemu: ", NULL); - tester_print("New hciemu instance created"); + bttester_print("New hciemu instance created"); } static void test_pre_setup(const void *test_data) { - struct test_data *data = tester_get_data(); + struct test_data *data = l_tester_get_data(tester); data->crypto = bt_crypto_new(); if (!data->crypto) { - tester_warn("Failed to setup crypto"); - tester_pre_setup_failed(); + bttester_warn("Failed to setup crypto"); + l_tester_pre_setup_failed(tester); return; } data->mgmt = mgmt_new_default(); if (!data->mgmt) { - tester_warn("Failed to setup management interface"); + bttester_warn("Failed to setup management interface"); bt_crypto_unref(data->crypto); - tester_pre_setup_failed(); + l_tester_pre_setup_failed(tester); return; } - if (tester_use_debug()) + if (bttester_use_debug()) mgmt_set_debug(data->mgmt, print_debug, "mgmt: ", NULL); mgmt_send(data->mgmt, MGMT_OP_READ_INDEX_LIST, MGMT_INDEX_NONE, 0, NULL, @@ -221,12 +222,7 @@ static void test_pre_setup(const void *test_data) static void test_post_teardown(const void *test_data) { - struct test_data *data = tester_get_data(); - - if (data->io_id > 0) { - g_source_remove(data->io_id); - data->io_id = 0; - } + struct test_data *data = l_tester_get_data(tester); if (data->crypto) { bt_crypto_unref(data->crypto); @@ -237,44 +233,38 @@ static void test_post_teardown(const void *test_data) data->hciemu = NULL; } -static void test_data_free(void *test_data) -{ - struct test_data *data = test_data; - - free(data); -} - static void test_add_condition(struct test_data *data) { data->unmet_conditions++; - tester_print("Test condition added, total %d", data->unmet_conditions); + bttester_print("Test condition added, total %d", + data->unmet_conditions); } static void test_condition_complete(struct test_data *data) { data->unmet_conditions--; - tester_print("Test condition complete, %d left", + bttester_print("Test condition complete, %d left", data->unmet_conditions); if (data->unmet_conditions > 0) return; - tester_test_passed(); + l_tester_test_passed(tester); } #define test_smp(name, data, setup, func) \ do { \ struct test_data *user; \ - user = calloc(1, sizeof(struct test_data)); \ + user = l_new(struct test_data, 1); \ if (!user) \ break; \ user->hciemu_type = HCIEMU_TYPE_BREDRLE; \ user->test_data = data; \ - tester_add_full(name, data, \ + l_tester_add_full(tester, name, data, \ test_pre_setup, setup, func, NULL, \ - test_post_teardown, 2, user, test_data_free); \ + test_post_teardown, 2, user, l_free); \ } while (0) static const uint8_t smp_nval_req_1[] = { 0x0b, 0x00 }; @@ -287,7 +277,7 @@ static const struct smp_req_rsp nval_req_1[] = { static const struct smp_data smp_server_nval_req_1_test = { .req = nval_req_1, - .req_count = G_N_ELEMENTS(nval_req_1), + .req_count = L_ARRAY_SIZE(nval_req_1), }; static const uint8_t smp_nval_req_2[7] = { 0x01 }; @@ -300,7 +290,7 @@ static const struct smp_req_rsp srv_nval_req_1[] = { static const struct smp_data smp_server_nval_req_2_test = { .req = srv_nval_req_1, - .req_count = G_N_ELEMENTS(srv_nval_req_1), + .req_count = L_ARRAY_SIZE(srv_nval_req_1), }; static const uint8_t smp_nval_req_3[] = { 0x01, 0xff }; @@ -313,7 +303,7 @@ static const struct smp_req_rsp srv_nval_req_2[] = { static const struct smp_data smp_server_nval_req_3_test = { .req = srv_nval_req_2, - .req_count = G_N_ELEMENTS(srv_nval_req_2), + .req_count = L_ARRAY_SIZE(srv_nval_req_2), }; static const uint8_t smp_basic_req_1[] = { 0x01, /* Pairing Request */ @@ -347,7 +337,7 @@ static const struct smp_req_rsp srv_basic_req_1[] = { static const struct smp_data smp_server_basic_req_1_test = { .req = srv_basic_req_1, - .req_count = G_N_ELEMENTS(srv_basic_req_1), + .req_count = L_ARRAY_SIZE(srv_basic_req_1), }; static const struct smp_req_rsp cli_basic_req_1[] = { @@ -361,7 +351,7 @@ static const struct smp_req_rsp cli_basic_req_1[] = { static const struct smp_data smp_client_basic_req_1_test = { .req = cli_basic_req_1, - .req_count = G_N_ELEMENTS(cli_basic_req_1), + .req_count = L_ARRAY_SIZE(cli_basic_req_1), }; static const uint8_t smp_basic_req_2[] = { 0x01, /* Pairing Request */ @@ -384,7 +374,7 @@ static const struct smp_req_rsp cli_basic_req_2[] = { static const struct smp_data smp_client_basic_req_2_test = { .req = cli_basic_req_2, - .req_count = G_N_ELEMENTS(cli_basic_req_1), + .req_count = L_ARRAY_SIZE(cli_basic_req_1), .mitm = true, }; @@ -393,7 +383,7 @@ static void user_confirm_request_callback(uint16_t index, uint16_t length, void *user_data) { const struct mgmt_ev_user_confirm_request *ev = param; - struct test_data *data = tester_get_data(); + struct test_data *data = l_tester_get_data(tester); struct mgmt_cp_user_confirm_reply cp; memset(&cp, 0, sizeof(cp)); @@ -423,7 +413,7 @@ static const struct smp_req_rsp cli_sc_req_1[] = { static const struct smp_data smp_client_sc_req_1_test = { .req = cli_sc_req_1, - .req_count = G_N_ELEMENTS(cli_sc_req_1), + .req_count = L_ARRAY_SIZE(cli_sc_req_1), .sc = true, }; @@ -449,7 +439,7 @@ static const struct smp_req_rsp cli_sc_req_2[] = { static const struct smp_data smp_client_sc_req_2_test = { .req = cli_sc_req_2, - .req_count = G_N_ELEMENTS(cli_sc_req_2), + .req_count = L_ARRAY_SIZE(cli_sc_req_2), .sc = true, }; @@ -460,26 +450,26 @@ static void client_connectable_complete(uint16_t opcode, uint8_t status, if (opcode != BT_HCI_CMD_LE_SET_ADV_ENABLE) return; - tester_print("Client set connectable status 0x%02x", status); + bttester_print("Client set connectable status 0x%02x", status); if (status) - tester_setup_failed(); + l_tester_setup_failed(tester); else - tester_setup_complete(); + l_tester_setup_complete(tester); } static void setup_powered_client_callback(uint8_t status, uint16_t length, const void *param, void *user_data) { - struct test_data *data = tester_get_data(); + struct test_data *data = l_tester_get_data(tester); struct bthost *bthost; if (status != MGMT_STATUS_SUCCESS) { - tester_setup_failed(); + l_tester_setup_failed(tester); return; } - tester_print("Controller powered on"); + bttester_print("Controller powered on"); bthost = hciemu_client_get_host(data->hciemu); bthost_set_cmd_complete_cb(bthost, client_connectable_complete, data); @@ -489,15 +479,15 @@ static void setup_powered_client_callback(uint8_t status, uint16_t length, static void make_pk(struct test_data *data) { if (!ecc_make_key(data->local_pk, data->local_sk)) { - tester_print("Failed to general local ECDH keypair"); - tester_setup_failed(); + bttester_print("Failed to general local ECDH keypair"); + l_tester_setup_failed(tester); return; } } static void setup_powered_client(const void *test_data) { - struct test_data *data = tester_get_data(); + struct test_data *data = l_tester_get_data(tester); const struct smp_data *smp = data->test_data; unsigned char param[] = { 0x01 }; @@ -505,7 +495,7 @@ static void setup_powered_client(const void *test_data) data->mgmt_index, user_confirm_request_callback, data, NULL); - tester_print("Powering on controller"); + bttester_print("Powering on controller"); mgmt_send(data->mgmt, MGMT_OP_SET_LE, data->mgmt_index, sizeof(param), param, NULL, NULL, NULL); @@ -529,16 +519,16 @@ static void pair_device_complete(uint8_t status, uint16_t length, const void *param, void *user_data) { if (status != MGMT_STATUS_SUCCESS) { - tester_warn("Pairing failed: %s", mgmt_errstr(status)); + bttester_warn("Pairing failed: %s", mgmt_errstr(status)); return; } - tester_print("Pairing succeedded"); + bttester_print("Pairing succeedded"); } static const void *get_pdu(const uint8_t *pdu) { - struct test_data *data = tester_get_data(); + struct test_data *data = l_tester_get_data(tester); const struct smp_data *smp = data->test_data; uint8_t opcode = pdu[0]; static uint8_t buf[65]; @@ -579,7 +569,7 @@ static const void *get_pdu(const uint8_t *pdu) static bool verify_random(const uint8_t rnd[16]) { - struct test_data *data = tester_get_data(); + struct test_data *data = l_tester_get_data(tester); uint8_t confirm[16]; if (!bt_crypto_c1(data->crypto, data->tk, data->rrnd, data->prsp, @@ -588,7 +578,7 @@ static bool verify_random(const uint8_t rnd[16]) return false; if (memcmp(data->pcnf, confirm, sizeof(data->pcnf)) != 0) { - tester_warn("Confirmation values don't match"); + bttester_warn("Confirmation values don't match"); return false; } @@ -620,13 +610,13 @@ static void smp_server(const void *data, uint16_t len, void *user_data) const void *pdu; if (len < 1) { - tester_warn("Received too small SMP PDU"); + bttester_warn("Received too small SMP PDU"); goto failed; } opcode = *((const uint8_t *) data); - tester_print("Received SMP opcode 0x%02x", opcode); + bttester_print("Received SMP opcode 0x%02x", opcode); if (test_data->counter >= smp->req_count) { test_condition_complete(test_data); @@ -638,7 +628,7 @@ static void smp_server(const void *data, uint16_t len, void *user_data) goto next; if (req->expect_len != len) { - tester_warn("Unexpected SMP PDU length (%u != %u)", + bttester_warn("Unexpected SMP PDU length (%u != %u)", len, req->expect_len); goto failed; } @@ -673,7 +663,7 @@ static void smp_server(const void *data, uint16_t len, void *user_data) } if (memcmp(req->expect, data, len) != 0) { - tester_warn("Unexpected SMP PDU"); + bttester_warn("Unexpected SMP PDU"); goto failed; } @@ -698,7 +688,7 @@ next: return; failed: - tester_test_failed(); + l_tester_test_failed(tester); } static void command_hci_callback(uint16_t opcode, const void *param, @@ -709,7 +699,7 @@ static void command_hci_callback(uint16_t opcode, const void *param, const void *expect_hci_param = smp->expect_hci_param; uint8_t expect_hci_len = smp->expect_hci_len; - tester_print("HCI Command 0x%04x length %u", opcode, length); + bttester_print("HCI Command 0x%04x length %u", opcode, length); if (opcode != smp->expect_hci_command) return; @@ -718,14 +708,14 @@ static void command_hci_callback(uint16_t opcode, const void *param, expect_hci_param = smp->expect_hci_func(&expect_hci_len); if (length != expect_hci_len) { - tester_warn("Invalid parameter size for HCI command"); - tester_test_failed(); + bttester_warn("Invalid parameter size for HCI command"); + l_tester_test_failed(tester); return; } if (memcmp(param, expect_hci_param, length) != 0) { - tester_warn("Unexpected HCI command parameter value"); - tester_test_failed(); + bttester_warn("Unexpected HCI command parameter value"); + l_tester_test_failed(tester); return; } @@ -740,7 +730,7 @@ static void smp_new_conn(uint16_t handle, void *user_data) const struct smp_req_rsp *req; const void *pdu; - tester_print("New SMP client connection with handle 0x%04x", handle); + bttester_print("New SMP client connection with handle 0x%04x", handle); data->handle = handle; @@ -754,7 +744,7 @@ static void smp_new_conn(uint16_t handle, void *user_data) if (!req->send) return; - tester_print("Sending SMP PDU"); + bttester_print("Sending SMP PDU"); pdu = get_pdu(req->send); bthost_send_cid(bthost, handle, SMP_CID, pdu, req->send_len); @@ -769,15 +759,15 @@ static void init_bdaddr(struct test_data *data) master_bdaddr = hciemu_get_master_bdaddr(data->hciemu); if (!master_bdaddr) { - tester_warn("No master bdaddr"); - tester_test_failed(); + bttester_warn("No master bdaddr"); + l_tester_test_failed(tester); return; } client_bdaddr = hciemu_get_client_bdaddr(data->hciemu); if (!client_bdaddr) { - tester_warn("No client bdaddr"); - tester_test_failed(); + bttester_warn("No client bdaddr"); + l_tester_test_failed(tester); return; } @@ -795,7 +785,7 @@ static void init_bdaddr(struct test_data *data) static void test_client(const void *test_data) { - struct test_data *data = tester_get_data(); + struct test_data *data = l_tester_get_data(tester); const struct smp_data *smp = data->test_data; struct mgmt_cp_pair_device cp; struct bthost *bthost; @@ -807,7 +797,7 @@ static void test_client(const void *test_data) test_add_condition(data); if (smp->expect_hci_command) { - tester_print("Registering HCI command callback"); + bttester_print("Registering HCI command callback"); hciemu_add_master_post_command_hook(data->hciemu, command_hci_callback, data); test_add_condition(data); @@ -823,25 +813,25 @@ static void test_client(const void *test_data) mgmt_send(data->mgmt, MGMT_OP_PAIR_DEVICE, data->mgmt_index, sizeof(cp), &cp, pair_device_complete, NULL, NULL); - tester_print("Pairing in progress"); + bttester_print("Pairing in progress"); } static void setup_powered_server_callback(uint8_t status, uint16_t length, const void *param, void *user_data) { if (status != MGMT_STATUS_SUCCESS) { - tester_setup_failed(); + l_tester_setup_failed(tester); return; } - tester_print("Controller powered on"); + bttester_print("Controller powered on"); - tester_setup_complete(); + l_tester_setup_complete(tester); } static void setup_powered_server(const void *test_data) { - struct test_data *data = tester_get_data(); + struct test_data *data = l_tester_get_data(tester); const struct smp_data *smp = data->test_data; unsigned char param[] = { 0x01 }; @@ -849,7 +839,7 @@ static void setup_powered_server(const void *test_data) data->mgmt_index, user_confirm_request_callback, data, NULL); - tester_print("Powering on controller"); + bttester_print("Powering on controller"); mgmt_send(data->mgmt, MGMT_OP_SET_LE, data->mgmt_index, sizeof(param), param, NULL, NULL, NULL); @@ -873,7 +863,7 @@ static void setup_powered_server(const void *test_data) static void test_server(const void *test_data) { - struct test_data *data = tester_get_data(); + struct test_data *data = l_tester_get_data(tester); const struct smp_data *smp = data->test_data; struct bthost *bthost; @@ -888,7 +878,7 @@ static void test_server(const void *test_data) bthost_hci_connect(bthost, data->ra, BDADDR_LE_PUBLIC); if (smp->expect_hci_command) { - tester_print("Registering HCI command callback"); + bttester_print("Registering HCI command callback"); hciemu_add_master_post_command_hook(data->hciemu, command_hci_callback, data); test_add_condition(data); @@ -897,7 +887,7 @@ static void test_server(const void *test_data) int main(int argc, char *argv[]) { - tester_init(&argc, &argv); + tester = bttester_init(&argc, &argv); test_smp("SMP Server - Basic Request 1", &smp_server_basic_req_1_test, @@ -926,5 +916,5 @@ int main(int argc, char *argv[]) &smp_client_sc_req_2_test, setup_powered_client, test_client); - return tester_run(); + return bttester_run(); } -- 2.26.3