Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp98466pxj; Fri, 7 May 2021 04:43:56 -0700 (PDT) X-Google-Smtp-Source: ABdhPJziiqH0YJZ1U7eIvTuoYjnEW5VufdTogQRfMAvwJxvJqvNvUe2hWEwNs3Oox0gbncqrT7WG X-Received: by 2002:a17:906:1684:: with SMTP id s4mr9427016ejd.506.1620387836534; Fri, 07 May 2021 04:43:56 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1620387836; cv=none; d=google.com; s=arc-20160816; b=ieZWyO5vgMFtuHj9H62Idu0x/LK8Xm3qGYMJi/H75QeYq3fRJ0HgOJWQx/ZOIljUuS 8LovIIf51YbFFlPXjR9ehDr2OKYXaHzwvluNTWVs0yp3wPXneGzGC9sh89c7rPz09gJ7 2AhhIgqCfE1/OpKTW4seBPGddAcPFLwBgK2yN46xADcBW0+flttd7UVohYmq0xEQisX6 fnSvtsRUd7H3tfZtZwZ6g0A0j9nwckwBRu5/MtoP+WFfhT0Myb5RMl+cIgwoK6OaAuVy S2jFqCoTkDC02DXPh6r0zBSqgjppkp+d7M0E1A5BBNAkKVFgtxIOto8ZuXskE5CLBdcG Wgpw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:to:references:message-id :content-transfer-encoding:cc:date:in-reply-to:from:subject :mime-version; bh=USn+CCgXy5BsA7cC2KG99OiWOHNrpMkBtcYjyszwmFg=; b=FYGhTQ/8RFKUDqNJYWBb+jq/ahU29LZEC/GcB7d1i8euu730V2zY3/e3v6Y9jD+IG3 dQLbbKrJisq25RsedkZUYu0JyPc8yDN9G5vcQTUzZYRCGwaWHZL0iclumf/u9dFlscSu 5Jc4fuiZsViLVdr7r7hI0zzq6hATQPgZplLk36rDHJTAqjmvfRDvktDs6nw3I2A8sNFO q89B4zP2oY2sxK6MViq/uTnauxGsaPwobxYsUiHxyAPjvDSrSB2SnbPB7w5SN2obxY9j cDeS+rMYAenTs3c6f5cVkVGOeWpAStic9saoRwSuxBevRRBEm97B+x/jjUqgJPKHf1fM Y45g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-bluetooth-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id f7si4787301edx.339.2021.05.07.04.43.32; Fri, 07 May 2021 04:43:56 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-bluetooth-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234870AbhEGIez convert rfc822-to-8bit (ORCPT + 99 others); Fri, 7 May 2021 04:34:55 -0400 Received: from coyote.holtmann.net ([212.227.132.17]:40441 "EHLO mail.holtmann.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230215AbhEGIey (ORCPT ); Fri, 7 May 2021 04:34:54 -0400 Received: from smtpclient.apple (p4fefc624.dip0.t-ipconnect.de [79.239.198.36]) by mail.holtmann.org (Postfix) with ESMTPSA id 4AFB1CECDB; Fri, 7 May 2021 10:41:45 +0200 (CEST) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.80.0.2.43\)) Subject: Re: [PATCH v1] Bluetooth: Fix alt settings for incoming SCO with transparent coding format From: Marcel Holtmann In-Reply-To: <20210408170159.19510-1-kiran.k@intel.com> Date: Fri, 7 May 2021 10:33:54 +0200 Cc: Bluetooth Kernel Mailing List , "Srivatsa, Ravishankar" , chethan.tumkur.narayan@intel.com, Lokendra Singh Content-Transfer-Encoding: 8BIT Message-Id: References: <20210408170159.19510-1-kiran.k@intel.com> To: Kiran K X-Mailer: Apple Mail (2.3654.80.0.2.43) Precedence: bulk List-ID: X-Mailing-List: linux-bluetooth@vger.kernel.org Hi Kiran, > For incoming SCO connection with transparent coding format, alt setting > of CVSD is getting applied instead of Transparent. > > Before fix: > < HCI Command: Accept Synchron.. (0x01|0x0029) plen 21 #2196 [hci0] 321.342548 > Address: 1C:CC:D6:E2:EA:80 (Xiaomi Communications Co Ltd) > Transmit bandwidth: 8000 > Receive bandwidth: 8000 > Max latency: 13 > Setting: 0x0003 > Input Coding: Linear > Input Data Format: 1's complement > Input Sample Size: 8-bit > # of bits padding at MSB: 0 > Air Coding Format: Transparent Data > Retransmission effort: Optimize for link quality (0x02) > Packet type: 0x003f > HV1 may be used > HV2 may be used > HV3 may be used > EV3 may be used > EV4 may be used > EV5 may be used >> HCI Event: Command Status (0x0f) plen 4 #2197 [hci0] 321.343585 > Accept Synchronous Connection Request (0x01|0x0029) ncmd 1 > Status: Success (0x00) >> HCI Event: Synchronous Connect Comp.. (0x2c) plen 17 #2198 [hci0] 321.351666 > Status: Success (0x00) > Handle: 257 > Address: 1C:CC:D6:E2:EA:80 (Xiaomi Communications Co Ltd) > Link type: eSCO (0x02) > Transmission interval: 0x0c > Retransmission window: 0x04 > RX packet length: 60 > TX packet length: 60 > Air mode: Transparent (0x03) > ........ >> SCO Data RX: Handle 257 flags 0x00 dlen 48 #2336 [hci0] 321.383655 > < SCO Data TX: Handle 257 flags 0x00 dlen 60 #2337 [hci0] 321.389558 >> SCO Data RX: Handle 257 flags 0x00 dlen 48 #2338 [hci0] 321.393615 >> SCO Data RX: Handle 257 flags 0x00 dlen 48 #2339 [hci0] 321.393618 >> SCO Data RX: Handle 257 flags 0x00 dlen 48 #2340 [hci0] 321.393618 > < SCO Data TX: Handle 257 flags 0x00 dlen 60 #2341 [hci0] 321.397070 >> SCO Data RX: Handle 257 flags 0x00 dlen 48 #2342 [hci0] 321.403622 >> SCO Data RX: Handle 257 flags 0x00 dlen 48 #2343 [hci0] 321.403625 >> SCO Data RX: Handle 257 flags 0x00 dlen 48 #2344 [hci0] 321.403625 >> SCO Data RX: Handle 257 flags 0x00 dlen 48 #2345 [hci0] 321.403625 > < SCO Data TX: Handle 257 flags 0x00 dlen 60 #2346 [hci0] 321.404569 > < SCO Data TX: Handle 257 flags 0x00 dlen 60 #2347 [hci0] 321.412091 >> SCO Data RX: Handle 257 flags 0x00 dlen 48 #2348 [hci0] 321.413626 >> SCO Data RX: Handle 257 flags 0x00 dlen 48 #2349 [hci0] 321.413630 >> SCO Data RX: Handle 257 flags 0x00 dlen 48 #2350 [hci0] 321.413630 > < SCO Data TX: Handle 257 flags 0x00 dlen 60 #2351 [hci0] 321.419674 > > After fix: > > < HCI Command: Accept Synchronou.. (0x01|0x0029) plen 21 #309 [hci0] 49.439693 > Address: 1C:CC:D6:E2:EA:80 (Xiaomi Communications Co Ltd) > Transmit bandwidth: 8000 > Receive bandwidth: 8000 > Max latency: 13 > Setting: 0x0003 > Input Coding: Linear > Input Data Format: 1's complement > Input Sample Size: 8-bit > # of bits padding at MSB: 0 > Air Coding Format: Transparent Data > Retransmission effort: Optimize for link quality (0x02) > Packet type: 0x003f > HV1 may be used > HV2 may be used > HV3 may be used > EV3 may be used > EV4 may be used > EV5 may be used >> HCI Event: Command Status (0x0f) plen 4 #310 [hci0] 49.440308 > Accept Synchronous Connection Request (0x01|0x0029) ncmd 1 > Status: Success (0x00) >> HCI Event: Synchronous Connect Complete (0x2c) plen 17 #311 [hci0] 49.449308 > Status: Success (0x00) > Handle: 257 > Address: 1C:CC:D6:E2:EA:80 (Xiaomi Communications Co Ltd) > Link type: eSCO (0x02) > Transmission interval: 0x0c > Retransmission window: 0x04 > RX packet length: 60 > TX packet length: 60 > Air mode: Transparent (0x03) > < SCO Data TX: Handle 257 flags 0x00 dlen 60 #312 [hci0] 49.450421 > < SCO Data TX: Handle 257 flags 0x00 dlen 60 #313 [hci0] 49.457927 >> HCI Event: Max Slots Change (0x1b) plen 3 #314 [hci0] 49.460345 > Handle: 256 > Max slots: 5 > < SCO Data TX: Handle 257 flags 0x00 dlen 60 #315 [hci0] 49.465453 >> SCO Data RX: Handle 257 flags 0x00 dlen 60 #316 [hci0] 49.470502 >> SCO Data RX: Handle 257 flags 0x00 dlen 60 #317 [hci0] 49.470519 > < SCO Data TX: Handle 257 flags 0x00 dlen 60 #318 [hci0] 49.472996 >> SCO Data RX: Handle 257 flags 0x00 dlen 60 #319 [hci0] 49.480412 > < SCO Data TX: Handle 257 flags 0x00 dlen 60 #320 [hci0] 49.480492 > < SCO Data TX: Handle 257 flags 0x00 dlen 60 #321 [hci0] 49.487989 >> SCO Data RX: Handle 257 flags 0x00 dlen 60 #322 [hci0] 49.490303 > < SCO Data TX: Handle 257 flags 0x00 dlen 60 #323 [hci0] 49.495496 >> SCO Data RX: Handle 257 flags 0x00 dlen 60 #324 [hci0] 49.500304 >> SCO Data RX: Handle 257 flags 0x00 dlen 60 #325 [hci0] 49.500311 > > Signed-off-by: Kiran K > Signed-off-by: Lokendra Singh > --- > net/bluetooth/hci_event.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) patch has been applied to bluetooth-next tree. Regards Marcel