Received-SPF: pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210430230501.603111-1-luiz.dentz@gmail.com> <20210511042654.8549-1-youling257@gmail.com>
In-Reply-To: <20210511042654.8549-1-youling257@gmail.com>
From:   Luiz Augusto von Dentz <luiz.dentz@gmail.com>
Date:   Tue, 11 May 2021 00:01:54 -0700
Message-ID: <CABBYNZLEiBzgM=Ur6YuFCNWu0w3E5nYN4ZBmQm95V=s9W9D8Aw@mail.gmail.com>
Subject: Re: [PATCH] Bluetooth: btusb: Fix failing to init controllers with
 operation firmware
To:     youling257 <youling257@gmail.com>
Cc:     "linux-bluetooth@vger.kernel.org" <linux-bluetooth@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Hi,

On Mon, May 10, 2021 at 9:27 PM youling257 <youling257@gmail.com> wrote:
>
> I test this patch no help. rmmod btusb, modprobe btusb.
>
>
> [    7.661739] Bluetooth: Core ver 2.22
> [    7.661762] NET: Registered protocol family 31
> [    7.661763] Bluetooth: HCI device and connection manager initialized
> [    7.661767] Bluetooth: HCI socket layer initialized
> [    7.661768] Bluetooth: L2CAP socket layer initialized
> [    7.661772] Bluetooth: SCO socket layer initialized
> [    7.686106] usbcore: registered new interface driver btusb
> [    7.689317] iwlwifi 0000:07:00.0: Detected Intel(R) Wi-Fi 6 AX200 160MHz, REV=0x340
> [    7.689789] Bluetooth: hci0: Firmware revision 0.0 build 118 week 15 2021
> [    7.694911] bluetooth hci0: Direct firmware load for intel/ibt-20-0-0.sfi failed with error -2
>
> [  230.746397] usbcore: registered new interface driver btusb
> [  230.750827] Bluetooth: hci0: Firmware revision 0.0 build 118 week 15 2021
> [  230.756450] bluetooth hci0: Direct firmware load for intel/ibt-20-0-0.sfi failed with error -2

The error shall be ignored in this case since it comes from
request_firmware we can't prevent it, if you don't see another error
after that means it can be ignored, that said perhaps we detect it
sooner by either attempting to stat the file or perhaps check if
revision comes back as all 0.

-- 
Luiz Augusto von Dentz