Received-SPF: pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210511175803.1609438-1-hj.tedd.an@gmail.com>
In-Reply-To: <20210511175803.1609438-1-hj.tedd.an@gmail.com>
From:   Luiz Augusto von Dentz <luiz.dentz@gmail.com>
Date:   Tue, 11 May 2021 11:07:59 -0700
Message-ID: <CABBYNZKMHFVD7Z8oKOs3W-QusezCmjbZAeZn98NHVYz2YdfdEQ@mail.gmail.com>
Subject: Re: [BlueZ PATCH] config: Show error if rst2man not found when
 manpages are enabled
To:     Tedd Ho-Jeong An <hj.tedd.an@gmail.com>
Cc:     "linux-bluetooth@vger.kernel.org" <linux-bluetooth@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Hi Tedd,

On Tue, May 11, 2021 at 11:02 AM Tedd Ho-Jeong An <hj.tedd.an@gmail.com> wrote:
>
> From: Tedd Ho-Jeong An <tedd.an@intel.com>
>
> This patch adds a check if the conversion tool is installed when the
> manpages is enabled, and show error if it is not installed.
> ---
>  configure.ac | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/configure.ac b/configure.ac
> index f445589b0..2b044f8e5 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -328,6 +328,9 @@ AC_ARG_ENABLE(manpages, AC_HELP_STRING([--enable-manpages],
>                                         [enable_manpages=${enableval}])
>  if (test "${enable_manpages}" != "no"); then
>         AC_CHECK_PROGS(RST2MAN, [rst2man rst2man.py], "no")
> +       if (test "${RST2MAN}" = "no" ); then
> +               AC_MSG_ERROR([rst2man is required])

I guess we can mention that it is typically packaged with
python-docutils e.g: rstman is required: install python-docutils or
alternatively we check python-docutils with pkgconfig since it will be
a hard dependency anyway.

> +       fi
>  fi
>  AM_CONDITIONAL(MANPAGES, test "${enable_manpages}" = "yes")
>  AM_CONDITIONAL(RUN_RST2MAN, test "${enable_manpages}" = "yes" && test "${RST2MAN}" != "no")
> --
> 2.26.3
>


-- 
Luiz Augusto von Dentz