Received-SPF: pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <6af830fc74d50c722ecb9855038a00bf6673d4e5.camel@hadess.net>
Subject: Re: [PATCH 1/1] Fix various memory leaks
From:   Bastien Nocera <hadess@hadess.net>
To:     Steve Grubb <sgrubb@redhat.com>, linux-bluetooth@vger.kernel.org
Date:   Thu, 13 May 2021 00:35:54 +0200
In-Reply-To: <20210512133932.4e2b4bd0@ivy-bridge>
References: <20210512133932.4e2b4bd0@ivy-bridge>
Content-Type: text/plain; charset="UTF-8"
User-Agent: Evolution 3.40.1 (3.40.1-1.fc34) 
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Precedence: bulk

On Wed, 2021-05-12 at 13:39 -0400, Steve Grubb wrote:
> diff --git a/obexd/plugins/filesystem.c b/obexd/plugins/filesystem.c
> index 09bff8ad0..44e3cf3d2 100644
> --- a/obexd/plugins/filesystem.c
> +++ b/obexd/plugins/filesystem.c
> @@ -415,7 +415,7 @@ static void *capability_open(const char *name,
> int oflag, mode_t mode,
>                         goto fail;
>                 }
>  
> -               object->buffer = g_string_new(buf);
> +               object->buffer = buf;
>  
>                 if (size)
>                         *size = object->buffer->len;

Pretty certain this is wrong. It might be best to split the patch up
into its individual parts so it's easier to merge the non-broken ones.