Received-SPF: pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Steve Grubb <sgrubb@redhat.com>
To:     linux-bluetooth@vger.kernel.org, Bastien Nocera <hadess@hadess.net>
Subject: Re: [PATCH 1/1] Fix various memory leaks
Date:   Wed, 12 May 2021 22:10:55 -0400
Message-ID: <11748148.O9o76ZdvQC@x2>
Organization: Red Hat
In-Reply-To: <6af830fc74d50c722ecb9855038a00bf6673d4e5.camel@hadess.net>
References: <20210512133932.4e2b4bd0@ivy-bridge> <6af830fc74d50c722ecb9855038a00bf6673d4e5.camel@hadess.net>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Precedence: bulk

On Wednesday, May 12, 2021 6:35:54 PM EDT Bastien Nocera wrote:
> On Wed, 2021-05-12 at 13:39 -0400, Steve Grubb wrote:
> > diff --git a/obexd/plugins/filesystem.c b/obexd/plugins/filesystem.c
> > index 09bff8ad0..44e3cf3d2 100644
> > --- a/obexd/plugins/filesystem.c
> > +++ b/obexd/plugins/filesystem.c
> > @@ -415,7 +415,7 @@ static void *capability_open(const char *name,
> > int oflag, mode_t mode,
> >                         goto fail;
> >                 }
> >  
> > -               object->buffer = g_string_new(buf);
> > +               object->buffer = buf;
> >  
> >                 if (size)
> >                         *size = object->buffer->len;
> 
> Pretty certain this is wrong. 

Yeah, now that you mention it...that is a GString object. I guess we 
g_free(buf) right after the g_string_new(). Should I resend just that one 
patch or do I need to regenerate all 7 emails?

-Steve