Received-SPF: pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210512133932.4e2b4bd0@ivy-bridge> <6af830fc74d50c722ecb9855038a00bf6673d4e5.camel@hadess.net>
 <11748148.O9o76ZdvQC@x2>
In-Reply-To: <11748148.O9o76ZdvQC@x2>
From:   Luiz Augusto von Dentz <luiz.dentz@gmail.com>
Date:   Thu, 13 May 2021 13:32:41 -0700
Message-ID: <CABBYNZ+1cCbHn6JaKM-GEAHQnZLr-SGRA=+fRiVd6haYqPaW+w@mail.gmail.com>
Subject: Re: [PATCH 1/1] Fix various memory leaks
To:     Steve Grubb <sgrubb@redhat.com>
Cc:     "linux-bluetooth@vger.kernel.org" <linux-bluetooth@vger.kernel.org>,
        Bastien Nocera <hadess@hadess.net>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Hi Steve,

On Wed, May 12, 2021 at 7:12 PM Steve Grubb <sgrubb@redhat.com> wrote:
>
> On Wednesday, May 12, 2021 6:35:54 PM EDT Bastien Nocera wrote:
> > On Wed, 2021-05-12 at 13:39 -0400, Steve Grubb wrote:
> > > diff --git a/obexd/plugins/filesystem.c b/obexd/plugins/filesystem.c
> > > index 09bff8ad0..44e3cf3d2 100644
> > > --- a/obexd/plugins/filesystem.c
> > > +++ b/obexd/plugins/filesystem.c
> > > @@ -415,7 +415,7 @@ static void *capability_open(const char *name,
> > > int oflag, mode_t mode,
> > >                         goto fail;
> > >                 }
> > >
> > > -               object->buffer = g_string_new(buf);
> > > +               object->buffer = buf;
> > >
> > >                 if (size)
> > >                         *size = object->buffer->len;
> >
> > Pretty certain this is wrong.
>
> Yeah, now that you mention it...that is a GString object. I guess we
> g_free(buf) right after the g_string_new(). Should I resend just that one
> patch or do I need to regenerate all 7 emails?

Please resend as v7, also while at it remove the signed-off-by as we
don't use that in userspace.

-- 
Luiz Augusto von Dentz