Received-SPF: pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <625ddaac272571a89451dbff5be28270cd63e15b.camel@gmail.com>
Subject: Re: [Bluez PATCH v1] core: Fix loading AVDTP options
From:   Tedd Ho-Jeong An <hj.tedd.an@gmail.com>
To:     Howard Chung <howardchung@google.com>,
        linux-bluetooth@vger.kernel.org, luiz.dentz@gmail.com
Cc:     chromeos-bluetooth-upstreaming@chromium.org,
        Yun-Hao Chung <howardchung@chromium.org>,
        mmandlik@chromium.org, apusaka@chromium.org
Date:   Tue, 18 May 2021 21:41:08 -0700
In-Reply-To: <20210507123246.Bluez.v1.1.I15d73dd47b94af906daa3f5a25d4fc5db8cc5b29@changeid>
References: <20210507123246.Bluez.v1.1.I15d73dd47b94af906daa3f5a25d4fc5db8cc5b29@changeid>
Content-Type: text/plain; charset="UTF-8"
User-Agent: Evolution 3.36.5 (3.36.5-2.fc32) 
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi Howard,

On Fri, 2021-05-07 at 12:32 +0800, Howard Chung wrote:
> From: Yun-Hao Chung <howardchung@chromium.org>
> 
> Fix misassigned AVDTP StreamMode option, which causes StreamMode not
> being set.
> Fix AVDTP SessionMode option not freed.
> 
> Reviewed-by: mmandlik@chromium.org
> Reviewed-by: apusaka@chromium.org

Reviewed-by: Tedd Ho-Jeong An <tedd.an@intel.com>

> ---
> 
>  src/main.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/src/main.c b/src/main.c
> index c32bda7d407d..7612d6984890 100644
> --- a/src/main.c
> +++ b/src/main.c
> @@ -774,9 +774,10 @@ static void parse_config(GKeyFile *config)
>  			DBG("Invalid mode option: %s", str);
>  			btd_opts.avdtp.session_mode = BT_IO_MODE_BASIC;
>  		}
> +		g_free(str);
>  	}
>  
> -	val = g_key_file_get_integer(config, "AVDTP", "StreamMode", &err);
> +	str = g_key_file_get_string(config, "AVDTP", "StreamMode", &err);
>  	if (err) {
>  		DBG("%s", err->message);
>  		g_clear_error(&err);
> @@ -791,6 +792,7 @@ static void parse_config(GKeyFile *config)
>  			DBG("Invalid mode option: %s", str);
>  			btd_opts.avdtp.stream_mode = BT_IO_MODE_BASIC;
>  		}
> +		g_free(str);
>  	}
>  
>  	parse_br_config(config);