Received-SPF: pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: VtCRChp2oGvc/TdYB4BPuEW8+GBKwT4YwWmbpKcDl6blkhofgrUr7Zg5hlsEezR6ZiiW4cXdzL
 UZAcko104ZFA==
IronPort-SDR: LWJoMuhyIaVjxauJG/K42plzCvW4V7b2tfJnOehYgh4zLuVy513jHXyrduoyUU48y68pP6iUMO
 1/M55rgnU7Ow==
Message-ID: <d09fc978849b33606d169a24f7405b31e334b066.camel@linux.intel.com>
Subject: Re: [PATCH BlueZ v2 1/5] mesh: Fix delivery of PB-ACK to acceptors
From:   Tedd Ho-Jeong An <tedd.an@linux.intel.com>
To:     Brian Gix <brian.gix@intel.com>, linux-bluetooth@vger.kernel.org
Cc:     inga.stotland@intel.com
Date:   Wed, 19 May 2021 11:30:44 -0700
In-Reply-To: <20210519182150.1680987-2-brian.gix@intel.com>
References: <20210519182150.1680987-1-brian.gix@intel.com>
         <20210519182150.1680987-2-brian.gix@intel.com>
Organization: Intel Corporation
Content-Type: text/plain; charset="UTF-8"
User-Agent: Evolution 3.36.5 (3.36.5-2.fc32) 
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi Brian,

On Wed, 2021-05-19 at 11:21 -0700, Brian Gix wrote:
> Rwmove unneeded initialization that prevented the Acceptor roll of ever

Normally checkpatch.pl is good at catching a typo but it couldn't catch "Rwmove".

> recognizing a valid PB-ACK.
> ---
>  mesh/pb-adv.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/mesh/pb-adv.c b/mesh/pb-adv.c
> index c74dae79f..83f922aa8 100644
> --- a/mesh/pb-adv.c
> +++ b/mesh/pb-adv.c
> @@ -358,7 +358,6 @@ static void pb_adv_packet(void *user_data, const uint8_t *pkt, uint16_t len)
>  		first = !session->link_id;
>  		session->link_id = link_id;
>  		session->last_peer_trans_num = 0xFF;
> -		session->local_acked = 0xFF;
>  		session->peer_trans_num = 0x00;
>  		session->local_trans_num = 0x7F;
>  		session->opened = true;

Regards,
Tedd