Received-SPF: pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <42d9c52a-bcc9-13e6-9b1d-d9a94ff2889f@panix.com>
In-Reply-To: <42d9c52a-bcc9-13e6-9b1d-d9a94ff2889f@panix.com>
From:   Luiz Augusto von Dentz <luiz.dentz@gmail.com>
Date:   Sun, 30 May 2021 17:29:25 -0700
Message-ID: <CABBYNZKqK6wEyrAL9y7+mPSWKr5CG=NnSEJK67Tt9ogimYA-zw@mail.gmail.com>
Subject: Re: Commit 9b16bfbf41 ("Bluetooth: btintel: Move operational checks
 after version check") causing BT FW loading problems
To:     "Kenneth R. Crudup" <kenny@panix.com>
Cc:     Luiz Augusto Von Dentz <luiz.von.dentz@intel.com>,
        "An, Tedd" <tedd.an@intel.com>,
        Marcel Holtmann <marcel@holtmann.org>,
        "linux-bluetooth@vger.kernel.org" <linux-bluetooth@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Hi Kenny,

On Fri, May 28, 2021 at 5:53 PM Kenneth R. Crudup <kenny@panix.com> wrote:
>
>
> My BT device is (apparently a Jefferson Peak device):
>
> >> Bus 003 Device 003: ID 8087:0026 Intel Corp.
>
> With this commit in place, loading the BT firmware after a cold start fails
> attempting to load the wrong(?) firmware:
>
> ----
> Bluetooth: hci0: Firmware revision 0.0 build 118 week 15 2021
> bluetooth hci0: Direct firmware load for intel/ibt-19-16-0.sfi failed with error -2
> Bluetooth: hci0: Failed to load Intel firmware file intel/ibt-19-16-0.sfi (-2)
> ----
>
> ... and a "git log" in the linux-firmware repo shows this file "ibt-19-16-0.sfi"
> never existed. Before this commit it was trying to load:
>
> ----
> Bluetooth: hci0: Bootloader revision 0.4 build 0 week 11 2017
> Bluetooth: hci0: Device revision is 2
> Bluetooth: hci0: Secure boot is enabled
> Bluetooth: hci0: OTP lock is enabled
> Bluetooth: hci0: API lock is enabled
> Bluetooth: hci0: Debug lock is disabled
> Bluetooth: hci0: Minimum firmware build 1 week 10 2014
> Bluetooth: hci0: Found device firmware: intel/ibt-19-32-4.sfi
> Bluetooth: hci0: Waiting for firmware download to complete
> Bluetooth: hci0: Firmware loaded in 1642369 usecs
> Bluetooth: hci0: Waiting for device to boot
> Bluetooth: hci0: Device booted in 17881 usecs
> Bluetooth: hci0: Found Intel DDC parameters: intel/ibt-19-32-4.ddc
> Bluetooth: hci0: Applying Intel DDC parameters completed
> Bluetooth: hci0: Firmware revision 0.0 build 121 week 7 2021
> Bluetooth: hci0: MSFT filter_enable is already on
> ----
>
> Let me know if anyone needs more info.

What exact kernel version are you testing this? Is it with Linus tree
or bluetooth-next? In case of the former you will probably need the
following commit:

https://git.kernel.org/pub/scm/linux/kernel/git/bluetooth/bluetooth-next.git/commit/?id=183dce5a7fd3040ced6a220b0aa536c926f10cd9

>
>         -Kenny
>
> --
> Kenneth R. Crudup  Sr. SW Engineer, Scott County Consulting, Orange County CA


-- 
Luiz Augusto von Dentz