Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp317800pxj; Thu, 3 Jun 2021 07:28:14 -0700 (PDT) X-Google-Smtp-Source: ABdhPJysqh1CMrzu4JumcOBlG76aCea0lw4ixe3dz2+Y1/KnPCJwvf8p0Pm88fdJeZDswqWp0e+a X-Received: by 2002:a05:6402:42d2:: with SMTP id i18mr114806edc.168.1622730494722; Thu, 03 Jun 2021 07:28:14 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1622730494; cv=none; d=google.com; s=arc-20160816; b=ORKOsQk68PY7pTsRiI8JcLnmgoO/uqBmhiG9r5thvlbKxfAA0TkbO3kvggXaDonsKi bbToQyGnJR4PB0F0DN+09L6ZHd4Hg95dVuw0hmDE/kschjhRKtxKZt9TIELsAiCt+3OI C6Bc30Mo6QMkKS0hf0OL6xeqoPddGubCpuaf7HdZhTC5WWksb0CV+XC1Nsph9cqKgzqI t45zGaqYFH+sCmtLL71HvD4Wnbjd9tg6Wh4nCd7oIh9yje1gloLJ3Go1O3Xt0rgMQp99 uMXaIp7ZO+/5BrdzGo9ophB/aRml8+bApK3LITOxXcWOwxaUlfmuY0+2JUS2xEEu9PAy uTvg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:to:references:message-id :content-transfer-encoding:cc:date:in-reply-to:from:subject :mime-version; bh=VRq77JmEwHKH1ik4QLVyBn6tyrIwSB7Ggejw5SwIC4M=; b=YjvwhlWUp4o0SYRAYbK8lz0FEDc6o4GgwvVirpeIpvMc+AkjF5efJxoWEa7lDnQ0dP mfB+Sxw6B+Ql3B90wg8oPmkJt8GtnIx1CUVlEMDzEtq8ZrcO2IBRsNN6QtIAjfoda5jU n9ZcJQZdO/JcQLNNt/vbYjZzvkzQj3DMcO2UCwDYuAlwilblLmpP8EAkWn/UEw/SWcm5 NM1Fam3r6i35NINExaDlWbLG6TidfzwOt18jCRGdzU34dmff8dcvLnBFT09jLde5AIPq Trj2szyyASPuzp/3ul0lx0Y6PTrfnNuIS46AGq8bakoR38hiFIpMsLMrzks1wWMZjHLm eMmg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-bluetooth-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id q14si2656989edb.609.2021.06.03.07.27.51; Thu, 03 Jun 2021 07:28:14 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-bluetooth-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230342AbhFCO2M convert rfc822-to-8bit (ORCPT + 99 others); Thu, 3 Jun 2021 10:28:12 -0400 Received: from coyote.holtmann.net ([212.227.132.17]:56696 "EHLO mail.holtmann.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230309AbhFCO2L (ORCPT ); Thu, 3 Jun 2021 10:28:11 -0400 Received: from smtpclient.apple (p4fefc9d6.dip0.t-ipconnect.de [79.239.201.214]) by mail.holtmann.org (Postfix) with ESMTPSA id 6C268CED1F; Thu, 3 Jun 2021 16:34:23 +0200 (CEST) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.100.0.2.22\)) Subject: Re: [PATCH v8 3/9] Bluetooth: btintel: Add a quirk for hfp offload usecase From: Marcel Holtmann In-Reply-To: <20210518104232.5431-3-kiran.k@intel.com> Date: Thu, 3 Jun 2021 16:26:25 +0200 Cc: linux-bluetooth@vger.kernel.org, ravishankar.srivatsa@intel.com, chethan.tumkur.narayan@intel.com Content-Transfer-Encoding: 8BIT Message-Id: References: <20210518104232.5431-1-kiran.k@intel.com> <20210518104232.5431-3-kiran.k@intel.com> To: Kiran K X-Mailer: Apple Mail (2.3654.100.0.2.22) Precedence: bulk List-ID: X-Mailing-List: linux-bluetooth@vger.kernel.org Hi Kiran, > Define a quirk to identify if intel controllers supports offload for > HFP. In *setup* function, driver sends vendor specific command to > check if controller supports offload. If offload is supports then > quirk flag is set > > Signed-off-by: Kiran K > Reviewed-by: Chethan T N > Reviewed-by: Srivatsa Ravishankar > --- > drivers/bluetooth/btintel.c | 28 ++++++++++++++++++++++++++++ > drivers/bluetooth/btintel.h | 5 +++++ > drivers/bluetooth/btusb.c | 2 ++ > include/net/bluetooth/hci.h | 7 +++++++ > 4 files changed, 42 insertions(+) I dislike mixing driver changes with core changes. So first please introduce a core feature or a quirk and then use it in the driver in a separate patch. Regards Marcel