Received-SPF: pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: m+SjC8WqfJvwOC1xUEkEWdRAcK2GTyZ5fjxIKECAqrOXXb+e14pHL4GU9Uaq4McHT4I/BmMMK7
 VWqT6uvIwjaA==
IronPort-SDR: Ae4Pp99ixCZ7We6HXO3PhzdABBnVYpyksXLqj/KtzBAv1zzr2HsLCRPWrl0YYePSU+pj+CnQzs
 fTTUl2hDxsEg==
Message-ID: <358e08e9ef4c4e9a0cf21dcf02dda74755384b76.camel@linux.intel.com>
Subject: Re: [PATCH BlueZ 1/2] tools/mgmt-tester: Adjust test setup complete
 check
From:   Tedd Ho-Jeong An <tedd.an@linux.intel.com>
To:     Inga Stotland <inga.stotland@intel.com>,
        linux-bluetooth@vger.kernel.org
Cc:     luiz.dentz@gmail.com
Date:   Thu, 03 Jun 2021 12:38:42 -0700
In-Reply-To: <20210603000416.171392-1-inga.stotland@intel.com>
References: <20210603000416.171392-1-inga.stotland@intel.com>
Organization: Intel Corporation
Content-Type: text/plain; charset="UTF-8"
User-Agent: Evolution 3.36.5 (3.36.5-2.fc32) 
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi Inga,

On Wed, 2021-06-02 at 17:04 -0700, Inga Stotland wrote:
> This changes check for setup complete in client_cmd_complete() callback
> from tester_setup_complete() to test_setup_condition_complete(). This
> allows for combining setup conditions when setup_bthost() is called.

Reviewed-by: Tedd Ho-Jeong An <tedd.an@intel.com>

> ---
>  tools/mgmt-tester.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/tools/mgmt-tester.c b/tools/mgmt-tester.c
> index 4dd3490c2..657b7aaa0 100644
> --- a/tools/mgmt-tester.c
> +++ b/tools/mgmt-tester.c
> @@ -5831,7 +5831,7 @@ static void client_cmd_complete(uint16_t opcode, uint8_t status,
>  	if (status)
>  		tester_setup_failed();
>  	else
> -		tester_setup_complete();
> +		test_setup_condition_complete(data);
>  }
>  
>  static void setup_bthost(void)
> @@ -5842,6 +5842,7 @@ static void setup_bthost(void)
>  
>  	bthost = hciemu_client_get_host(data->hciemu);
>  	bthost_set_cmd_complete_cb(bthost, client_cmd_complete, data);
> +	test_add_setup_condition(data);
>  
>  	if (data->hciemu_type == HCIEMU_TYPE_LE ||
>  		test->client_enable_adv) {

Regards,
Tedd