Received-SPF: pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210606063719.339794-1-inga.stotland@intel.com>
In-Reply-To: <20210606063719.339794-1-inga.stotland@intel.com>
From:   Luiz Augusto von Dentz <luiz.dentz@gmail.com>
Date:   Mon, 7 Jun 2021 16:50:18 -0700
Message-ID: <CABBYNZL9vMY5cuwi0j40Z_aq+Ys-DeEnSMjgUrtD-SKi7YkDGg@mail.gmail.com>
Subject: Re: [PATCH BlueZ 00/11] Convert tester tools to use ELL
To:     Inga Stotland <inga.stotland@intel.com>
Cc:     "linux-bluetooth@vger.kernel.org" <linux-bluetooth@vger.kernel.org>,
        "An, Tedd" <tedd.an@intel.com>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Hi Inga,

On Sat, Jun 5, 2021 at 11:37 PM Inga Stotland <inga.stotland@intel.com> wrote:
>
> This patch set contains non-interactive tester tools modified
> to use ELL primitives in order to remove dependencies on GLib.
>
> Two new files emulator/hciemu-ell.c and src/shared/bttester.c are
> created as an intermediate step before removing their GLib-based counterparts
> subject to the vetting/approval of this patch set.
>
> Inga Stotland (11):
>   shared/bttester: tester framework wrapper to use ELL
>   emulator/hciemu: Create ELL based version of hciemu
>   tools/gap-tester: Convert to use ELL library
>   tools/sco-tester: Convert to use ELL library
>   tools/userchan-tester: Convert to use ELL library
>   tools/smp-tester: Convert to use ELL library
>   tools/bnep-tester: Convert to use ELL library
>   tools/l2cap-tester: Convert to use ELL library
>   tools/mgmt-tester: Convert to use ELL library
>   tools/rfcomm-tester: Convert to use ELL library
>   tools/hci-tester: Convert to use ELL library
>
>  Makefile.am             |   4 +-
>  Makefile.tools          |  36 +-
>  emulator/hciemu-ell.c   | 641 +++++++++++++++++++++++++++++++++
>  src/shared/bttester.c   | 279 +++++++++++++++
>  src/shared/bttester.h   |  32 ++
>  tools/bnep-tester.c     | 115 +++---
>  tools/gap-tester.c      | 107 +++---
>  tools/hci-tester.c      | 289 ++++++++-------
>  tools/l2cap-tester.c    | 680 ++++++++++++++++++-----------------
>  tools/mgmt-tester.c     | 772 ++++++++++++++++++++--------------------
>  tools/rfcomm-tester.c   | 290 +++++++--------
>  tools/sco-tester.c      | 231 ++++++------
>  tools/smp-tester.c      | 210 ++++++-----
>  tools/userchan-tester.c | 151 ++++----
>  14 files changed, 2391 insertions(+), 1446 deletions(-)
>  create mode 100644 emulator/hciemu-ell.c
>  create mode 100644 src/shared/bttester.c
>  create mode 100644 src/shared/bttester.h
>
> --
> 2.26.3

Just a heads-up that it may take a little longer to get to this set
since we are dealing with LL Privacy we want to include tests for it
first before we change the whole environment to use ELL.

-- 
Luiz Augusto von Dentz